Date: Tue, 17 Jan 2006 21:39:07 +1100 From: Sam Lawrance <boris@brooknet.com.au> To: Doug Barton <dougb@FreeBSD.org> Cc: ports@FreeBSD.org, Pav Lucistnik <pav@FreeBSD.org> Subject: Re: cvs commit: ports/mail/dk-milter Makefile pkg-plist ports/mail/dk-milter/files milter-dk.sh.in Message-ID: <8F69821A-31A2-4E2D-A9E9-5CE1BEB2EE1F@brooknet.com.au> In-Reply-To: <43CC3140.9040604@FreeBSD.org> References: <200601150911.k0F9B6eG062331@repoman.freebsd.org> <43CC3140.9040604@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Over to ports@ ... On 17/01/2006, at 10:50 AM, Doug Barton wrote: > Pav Lucistnik wrote: >> pav 2006-01-15 09:11:04 UTC >> >> FreeBSD ports repository >> >> Modified files: >> mail/dk-milter Makefile pkg-plist >> mail/dk-milter/files milter-dk.sh.in >> Log: >> - Convert RC script to rc_subr >> >> PR: ports/91595 http://www.FreeBSD.org/cgi/query- >> pr.cgi?pr=91595 >> Submitted by: Hirohisa Yamaguchi <umq@ueo.co.jp> >> >> Revision Changes Path >> 1.6 +3 -2 ports/mail/dk-milter/Makefile >> 1.2 +43 -48 ports/mail/dk-milter/files/milter-dk.sh.in >> 1.2 +0 -1 ports/mail/dk-milter/pkg-plist >> >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/ >> Makefile.diff?&r1=1.5&r2=1.6&f=h >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/files/ >> milter-dk.sh.in.diff?&r1=1.1&r2=1.2&f=h >> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/dk-milter/pkg- >> plist.diff?&r1=1.1&r2=1.2&f=h > > It's not a big enough issue to warrant a change for this port, but in > general it's a good idea if the name of the rc.d file is the same > as what > the script PROVIDE's. This removes one potential source of > confusion for users. Is it worth a patch to portlint? There are probably a stack of other rc-related things that could be checked for, too. For example, if an rc script is in the packing list, warn to use USE_RC_SUBR. Others?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8F69821A-31A2-4E2D-A9E9-5CE1BEB2EE1F>