Date: Sat, 3 May 2003 23:34:24 -0500 From: Juli Mallett <jmallett@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: perforce@freebsd.org Subject: Re: PERFORCE change 30435 for review Message-ID: <20030503233424.A8651@FreeBSD.org> In-Reply-To: <20030503.220139.44793868.imp@bsdimp.com>; from imp@bsdimp.com on Sat, May 03, 2003 at 10:01:39PM -0600 References: <200305030240.h432elND072264@repoman.freebsd.org> <20030503.220139.44793868.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* "M. Warner Losh" <imp@bsdimp.com> [ Date: 2003-05-03 ] [ w.r.t. Re: PERFORCE change 30435 for review ] > In message: <200305030240.h432elND072264@repoman.freebsd.org> > Juli Mallett <jmallett@freebsd.org> writes: > : http://perforce.freebsd.org/chv.cgi?CH=30435 > : > : Change 30435 by jmallett@jmallett_dalek on 2003/05/02 19:40:13 > : > : Erk, remove redundant call to cp0_status_read. > : > : Affected files ... > : > : .. //depot/projects/mips/sys/mips/include/cpufunc.h#8 edit > : > : Differences ... > : > : ==== //depot/projects/mips/sys/mips/include/cpufunc.h#8 (text+ko) ==== > : > : @@ -38,7 +38,6 @@ > : { > : register_t s; > : > : - s = mips_cp0_status_read(); > : mips_cp0_status_write((s = mips_cp0_status_read()) & ~MIPS_SR_IE); > : return (s); > : } > > Sure this is really redundant and not there for some weird mips box's > pipeline delay requirements? I just forgot to dd the line after I decided to nest it. -- juli mallett. email: jmallett@freebsd.org; efnet: juli;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030503233424.A8651>