Date: Fri, 17 Dec 2004 14:52:00 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: Nik Clayton <nik@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile Message-ID: <20041217125200.GA61177@ip.net.ua> In-Reply-To: <20041217112053.GK17158@clan.nothing-going-on.org> References: <200412161955.iBGJtvIO060191@repoman.freebsd.org> <20041217112053.GK17158@clan.nothing-going-on.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Nik, On Fri, Dec 17, 2004 at 11:20:54AM +0000, Nik Clayton wrote: > On Thu, Dec 16, 2004 at 07:55:57PM +0000, Ruslan Ermilov wrote: > > Previous revision didn't fix all cases. For example, > > testing for variables that are always defined (e.g., > > "make -V CC") would still print a false warning. Fix > > this by only passing a submake the MAKEOBJDIRPREFIX=3D* > > argument if it was present. As a result, we loose > > the check for -DMAKEOBJDIRPREFIX, or an esoteric > > "MAKEOBJDIRPREFIX =3D foo" (with embedded spaces), but > > these are unorthodox enough to not care about them. > > =20 > > The make(1) bug mentioned in the previous revision > > was just fixed in make/main.c,v 1.109. >=20 > Do you have test cases for these issues? They should be added to=20 > tools/regression/usr.bin/make. >=20 I know about tools/regression/usr.bin/make (as could be seen =66rom my commits there). Unfortunately, the testcase for this bug is somewhat hard to exploit. On my i386 testbox, I could only reproduce it under certain conditions, like the current working directory, etc. On amd64, it was always easier (I don't know why). The testcase may be as simple as this: $ env MAKEFLAGS=3D"-f /dev/null" make -V /nonexistent make: cannot open /nonexistent. $ echo $? 2 The bug is that the value of "/nonexistent" will replace the value of "/dev/null". Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBwtZwqRfpzJluFF4RAnYrAJwO2JulZKOnqboh36cwROPi2r0QjQCgm58Q sGJONEkK7Iwaf6s2oukH7l0= =o3Wk -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041217125200.GA61177>