Date: Sat, 13 Aug 2016 16:39:28 +0200 From: Bernard Spil <brnrd@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r420150 - in head/security/letskencrypt: . files Message-ID: <a57dcf487fa5fdc3499121dcd3b31979@imap.brnrd.eu> In-Reply-To: <A6276C8A-FD16-4C8F-BCCC-5A9532A70804@adamw.org> References: <201608122317.u7CNHx6M069763@repo.freebsd.org> <A6276C8A-FD16-4C8F-BCCC-5A9532A70804@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2016-08-13 16:20, Adam Weinberger wrote: >> On 12 Aug, 2016, at 17:17, Bernard Spil <brnrd@freebsd.org> wrote: >> >> Author: brnrd >> Date: Fri Aug 12 23:17:58 2016 >> New Revision: 420150 >> URL: https://svnweb.freebsd.org/changeset/ports/420150 >> >> Log: >> security/letskencrypt: Allow configurable license agreement >> >> - Backport upstream fixes for -a option (license agreement URL) >> - Bump PORTREVISION > > Hi Bernard, > > I'm confused about what I'm supposed to do here. > > It looks like the new license URL was added as default: > >> Added: head/security/letskencrypt/files/patch-main.c >> ============================================================================== >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/security/letskencrypt/files/patch-main.c Fri Aug 12 23:17:58 >> 2016 (r420150) >> @@ -0,0 +1,55 @@ >> + >> ++#define AGREEMENT "https://letsencrypt.org" \ >> ++ "/documents/LE-SA-v1.1.1-August-1-2016.pdf" > > ... but the pkg-message change says that I have to add arguments to > the invocation: > >> Modified: head/security/letskencrypt/files/pkg-message.in >> ============================================================================== >> --- head/security/letskencrypt/files/pkg-message.in Fri Aug 12 >> 23:02:52 2016 (r420149) >> +++ head/security/letskencrypt/files/pkg-message.in Fri Aug 12 >> 23:17:58 2016 (r420150) >> @@ -1,4 +1,15 @@ >> >> +LetsEncrypt's ACME servers have changed the LE license >> +agreement. To successfully run renewal you have to add >> + >> + -a https://letsencrypt.org/documents/LE-SA-v1.1.1-August-1-2016.pdf >> + >> +to the command invocation. > > The files/letskencrypt.sh.in doesn't contain that argument. > > So is it set automatically? Do I need to alter my letskencrypt.sh, or > is the pkg-message inaccurate? > > # Adam Hi Adam, Correct, that pkg-message update is not required. I've held back on committing not to have unneccessary commits. After updating this just runs without supplying -a. The new -a parameter has been added to facilitate future changes in the license agreement. Additionally, this is only required when you create a new account key. Any subsequent requests with the original account key do NOT need this license agreement update. Cheers, Bernard.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a57dcf487fa5fdc3499121dcd3b31979>