Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 2 May 2019 19:13:31 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r347031 - head/sys/net
Message-ID:  <201905021913.x42JDVIK058680@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste
Date: Thu May  2 19:13:31 2019
New Revision: 347031
URL: https://svnweb.freebsd.org/changeset/base/347031

Log:
  iflib: remove assertion that isc_capabilities is nonzero
  
  It's atypical, but not invalid, for a driver to pass no capabilities.
  
  Submitted by:	Gerald Aryeetey <aryeeteygerald_rogers.com>
  Reviewed by:	shurd
  MFC after:	1 week
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D20142

Modified:
  head/sys/net/iflib.c

Modified: head/sys/net/iflib.c
==============================================================================
--- head/sys/net/iflib.c	Thu May  2 19:02:16 2019	(r347030)
+++ head/sys/net/iflib.c	Thu May  2 19:13:31 2019	(r347031)
@@ -4584,7 +4584,6 @@ iflib_device_register(device_t dev, void *sc, if_share
 	ctx->ifc_txrx = *scctx->isc_txrx;
 
 #ifdef INVARIANTS
-	MPASS(scctx->isc_capabilities);
 	if (scctx->isc_capabilities & IFCAP_TXCSUM)
 		MPASS(scctx->isc_tx_csum_flags);
 #endif
@@ -4825,7 +4824,6 @@ iflib_pseudo_register(device_t dev, if_shared_ctx_t sc
 	ifmedia_set(&ctx->ifc_media, IFM_ETHER | IFM_AUTO);
 
 #ifdef INVARIANTS
-	MPASS(scctx->isc_capabilities);
 	if (scctx->isc_capabilities & IFCAP_TXCSUM)
 		MPASS(scctx->isc_tx_csum_flags);
 #endif



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905021913.x42JDVIK058680>