Date: Tue, 12 Feb 2019 21:13:30 +0100 From: Kristof Provost <kp@freebsd.org> To: Eric van Gyzen <eric@vangyzen.net> Cc: Pete French <petefrench@ingresso.co.uk>, "Andrey V. Elsukov" <bu7cher@yandex.ru>, freebsd-stable@freebsd.org, freebsd-current <freebsd-current@freebsd.org> Subject: Re: Networking panic on 12 - found the cause Message-ID: <20190212201330.GK8450@vega.codepro.be> In-Reply-To: <0a0f2668-19f7-ad62-dff4-e2997e57ea5c@vangyzen.net> References: <E1gr2IV-000BqA-VD@dilbert.ingresso.co.uk> <4a350f47-eaca-5aca-9268-bf7a6618e71c@yandex.ru> <cc6e7f23-6dfd-e6f7-b001-288da9edc58c@ingresso.co.uk> <0a0f2668-19f7-ad62-dff4-e2997e57ea5c@vangyzen.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-02-12 13:54:21 (-0600), Eric van Gyzen <eric@vangyzen.net> wrote: > I see the same behavior on head (and stable/12). > > (kgdb) f > #16 0xffffffff80ce5331 in ether_output_frame (ifp=0xfffff80003672800, > m=0xfffff8000c88b100) at /usr/src/sys/net/if_ethersubr.c:468 > 468 switch (pfil_run_hooks(V_link_pfil_head, &m, ifp, PFIL_OUT, > > 0xffffffff80ce5321 <+81>: mov %gs:0x0,%rax > 0xffffffff80ce532a <+90>: mov 0x500(%rax),%rax > => 0xffffffff80ce5331 <+97>: mov 0x28(%rax),%rax > > I think this is part of the V_link_pfil_head. I'm not very familiar > with vnet. Does this need a CURVNET_SET(), maybe in garp_rexmit()? > Yes. I posted a proposed patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235699 Basically we get called through a timer, so there's no vnet context. It needs to be set, and then we can safely use any V_ variables. Regards, Kristof
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190212201330.GK8450>