Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Aug 2013 11:54:12 GMT
From:      Boris Samorodov <bsam@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/181213: [patch] audio/twolame: add ftp/curl dependency
Message-ID:  <201308101154.r7ABsC6l025213@oldred.freebsd.org>
Resent-Message-ID: <201308101200.r7AC00Mt083570@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         181213
>Category:       ports
>Synopsis:       [patch] audio/twolame: add ftp/curl dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 10 12:00:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Boris Samorodov
>Release:        FreeBSD 10-amd64
>Organization:
BSDprint
>Environment:
FreeBSD BB049.int.wart.ru 10.0-CURRENT FreeBSD 10.0-CURRENT #50 r253993: Tue Aug  6 20:03:20 SAMT 2013     bsam@BB049.int.wart.ru:/usr/obj/usr/src/sys/BB64X  amd64
>Description:
After recent ftp/curl upgrade I get this:
-----
% pkg_libchk -a
twolame-0.3.13: /usr/local/bin/twolame misses libFLAC.so.10
-----

Analysis:
The port has a direct dependency (showed above). And the dependency should be listed at audio/twolame itself. And this port should bump PORTREVISION if library at ftp/curl changes.
>How-To-Repeat:
Upgrade ftp/curl to new version while having audio/twolame built with an older ftp/curl version.
>Fix:
. add ftp/curl;
. bump PORTREVISION (for ftp/curl library version changes).

Patch attached with submission follows:

Index: Makefile
===================================================================
--- Makefile	(revision 324469)
+++ Makefile	(working copy)
@@ -7,6 +7,7 @@
 
 PORTNAME=	twolame
 PORTVERSION=	0.3.13
+PORTREVISION=	1
 CATEGORIES=	audio
 MASTER_SITES=	SF \
 		http://www.ecs.soton.ac.uk/~njh/twolame/
@@ -14,7 +15,8 @@
 MAINTAINER=	multimedia@FreeBSD.org
 COMMENT=	MPEG Audio Layer 2 encoder
 
-LIB_DEPENDS=	sndfile.1:${PORTSDIR}/audio/libsndfile
+LIB_DEPENDS=	sndfile.1:${PORTSDIR}/audio/libsndfile \
+		FLAC:${PORTSDIR}/audio/flac
 
 USE_GMAKE=	yes
 USE_GNOME=	gnomehack pkgconfig


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201308101154.r7ABsC6l025213>