Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 28 Aug 2004 16:22:07 +0200
From:      Heiner <h.eichmann@gmx.de>
To:        freebsd-ports-bugs@FreeBSD.org
Cc:        reinhard.lenninger@web.de
Subject:   Re: ports/71010: port k3b: detection of TEAC-R56S fails due to error in patchfile
Message-ID:  <200408281622.07951.h.eichmann@gmx.de>
In-Reply-To: <Pine.LNX.4.44.0408280004070.27681-100000@pancho>
References:  <Pine.LNX.4.44.0408280004070.27681-100000@pancho>

next in thread | previous in thread | raw e-mail | index | archive | help

--Boundary-00=_PUJMBhpniOGmdRq
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Thanks for the report. A problem with the suggested patch is, that all drives 
named CD-R56Sxxxxx are affected, not only those by TAEC. The attached patch 
should fix this. The reporter should test it, as I do not have a TEAC drive. 
If it works it can be committed.


Heiner


--Boundary-00=_PUJMBhpniOGmdRq
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="patch"

--- files/patch-src-device-k3bdevice.cpp.orig	Tue Jul 20 03:19:58 2004
+++ files/patch-src-device-k3bdevice.cpp	Sat Aug 28 15:57:16 2004
@@ -33,21 +33,21 @@
    cmd[0] = MMC::GET_CONFIGURATION;
    cmd[8] = 8;
    if( cmd.transport( TR_DIR_READ, header, 8 ) ) {
-@@ -769,6 +779,14 @@
-       m_bufferSize = 1024;
-       d->burnfree = false;
-     }
-+    else if( description().startsWith("CD-R56S") ) {
-+      m_writeModes |= TAO;
-+      d->deviceType |= CDROM|CDR;
-+      m_maxWriteSpeed = 6;
-+      m_maxReadSpeed = 24;
-+      m_bufferSize = 1302;
-+      d->burnfree = false;
-+    }
+@@ -752,6 +762,14 @@
+     m_bufferSize = 1024;
+     d->burnfree = false;
    }
-   else if( vendor().startsWith("HP") ) {
-     if( description().startsWith("CD-Writer 6020") ) {
++  else if( vendor().startsWith("TEAC") && description().startsWith("CD-R56S") ) {
++    m_writeModes |= TAO;
++    d->deviceType |= CDROM|CDR;
++    m_maxWriteSpeed = 6;
++    m_maxReadSpeed = 24;
++    m_bufferSize = 1302;
++    d->burnfree = false;
++  }
+   else if( vendor().startsWith("MATSHITA") ) {
+     if( description().startsWith("CD-R   CW-7501") ) {
+       m_writeModes = TAO|SAO;
 @@ -2559,10 +2577,12 @@
  {
    // if the device is already opened we do not close it

--Boundary-00=_PUJMBhpniOGmdRq--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200408281622.07951.h.eichmann>