Date: Sat, 04 Aug 2018 22:29:09 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 230354] emulators/libdsk: Update to 1.4.2 Message-ID: <bug-230354-7788-nhtoPUn69Q@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230354-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-230354-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230354 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org --- Comment #3 from Tobias Kortkamp <tobik@freebsd.org> --- Comment on attachment 195847 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D195847 Update +.for i in ${DOCS} + ${INSTALL_DATA} ${WRKSRC}/doc/${i} ${STAGEDIR}${DOCSDIR} +.endfor More readable and better since it runs ${INSTALL_DATA} only once: cd ${WRKSRC}/doc && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR} +DOCS=3D apridisk.html cfi.html libdsk.lyx libdsk.pdf \ + libdsk.txt libdskrc.sample protocol.txt README TODO Just use PORTDOCS here instead and remove the PLIST_FILES bit below again. +.if ${PORT_OPTIONS:MDOCS} +PLIST_FILES+=3D ${PORTDOCS}${DOCSDIR}/README ${PORTDOCS}${DOCSDIR}/TODO \ + ${PORTDOCS}${DOCSDIR}/apridisk.html ${PORTDOCS}${DOCSDIR}/cfi.html \ + ${PORTDOCS}${DOCSDIR}/libdsk.lyx ${PORTDOCS}${DOCSDIR}/libdsk.pdf \ + ${PORTDOCS}${DOCSDIR}/libdsk.txt ${PORTDOCS}${DOCSDIR}/libdskrc.sample \ + ${PORTDOCS}${DOCSDIR}/protocol.txt +.endif This is not necessary when using PORTDOCS, but you should read up on options helpers variables either way [1]. Variables should always be set before any targets [2]. [1] https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html= #options-variables [2] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230354-7788-nhtoPUn69Q>