Date: Sun, 2 Jul 2000 01:08:10 -0700 (PDT) From: Brian Feldman <green@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern kern_ktrace.c sys_generic.c uipc_syscalls.c src/sys/svr4 svr4_stream.c src/sys/sys ktrace.h Message-ID: <200007020808.BAA17019@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
green 2000/07/02 01:08:10 PDT
Modified files:
sys/kern kern_ktrace.c sys_generic.c
uipc_syscalls.c
sys/svr4 svr4_stream.c
sys/sys ktrace.h
Log:
Modify ktrace's general I/O tracing, ktrgenio(), to use a struct uio *
instead of a struct iovec * array and int len. Get rid of stupidly trying
to allocate all of the memory and copyin()ing the entire iovec[], and
instead just do the proper VOP_WRITE() in ktrwrite() using a copy of
the struct uio that the syscall originally used.
This solves the DoS which could easily be performed; to work around the
DoS, one could also remove "options KTRACE" from the kernel. This is
a very strong MFC candidate for 4.1.
Found by: art@OpenBSD.org
Revision Changes Path
1.37 +29 -35 src/sys/kern/kern_ktrace.c
1.58 +37 -16 src/sys/kern/sys_generic.c
1.70 +15 -7 src/sys/kern/uipc_syscalls.c
1.14 +15 -7 src/sys/svr4/svr4_stream.c
1.21 +2 -2 src/sys/sys/ktrace.h
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007020808.BAA17019>