Date: Fri, 22 Aug 2014 18:31:39 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Jilles Tjoelker <jilles@stack.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Roger Pau Monn? <royger@FreeBSD.org>, src-committers@freebsd.org, Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: svn commit: r265003 - head/secure/usr.sbin/sshd Message-ID: <20140822153139.GN2737@kib.kiev.ua> In-Reply-To: <20140822134353.GA21891@stack.nl> References: <201404270528.s3R5SEIm054377@svn.freebsd.org> <53F4B381.5010205@FreeBSD.org> <20140820151310.GB2737@kib.kiev.ua> <53F4BC9B.3090405@FreeBSD.org> <53F4BEB1.6070000@FreeBSD.org> <53F4C022.5050804@FreeBSD.org> <20140821080541.GE2737@kib.kiev.ua> <53F5D42E.9080908@FreeBSD.org> <20140821123246.GH2737@kib.kiev.ua> <20140822134353.GA21891@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
--LlyFhrrzptpgNMGs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 22, 2014 at 03:43:53PM +0200, Jilles Tjoelker wrote: > This is good and necessary for SA_SIGINFO (because of the type of the > SIG_DFL and SIG_IGN constants, and because POSIX says so in the > description of SA_RESETHAND in the sigaction() page). However, there > seems no reason to clear the other flags, which have no effect when the > disposition is SIG_DFL or SIG_IGN but have historically always been > preserved. (Slight exception: if kernel code erroneously loops on > ERESTART, it will eat CPU time iff SA_RESTART is set, independent of the > signal's disposition.) Well, I already committed the patch with several bugs fixed comparing with what was mailed, before your feedback arrived. Do you consider it is important enough to revert the resetting of other flags ? In particular, your note about the traditional historic behaviour makes me wonder. I do not see why SA_SIGINFO is so special that it must be reset, while other flags are not. The absence of the cases where the default/ignored disposition is affected by the flags seems rather arbitrary. >=20 > I notice a bug in POSIX here: it should specify that execve() clear > SA_SIGINFO bits when it resets signals to SIG_DFL. >=20 > --=20 > Jilles Tjoelker --LlyFhrrzptpgNMGs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJT92JbAAoJEJDCuSvBvK1ByhsP/iggX+JU9BLduvXkQJMEXN7F aUuKwaidYPaulVVHAMHRHy8Bs2U3ZI3nmmBfGa8penqlJgm7U10dtRLRFgbufe+6 CgC293/eBU9U/5exF8M8hv36ieF2TqdAXKFjKDMWOaY4tFeoedP0ZR30Ywz6IyTt dIYSYD1ZP+5ChsnkjWV0ykMHRiO0cfYjOdNyYt81Pyc+V1imUFxPjjb13nuZRcde mjZOOY6VUnY2R4LPvT2uL62nDjrojD7Xz8SqWVVVx8GVpRVrwCIcz9S4uA6PYykV fkRIzf2SlgwTLwgLhPl4TkIlC59OWhPpEBPGnk/PRXNWHGO+4Ky1j0hBuAJdefhd Dafs4VROhWKGSj81mC5s0+L/3XuEnmD6gD/EzAVF9c2rx1zQKZhB5HjstlpgNtzg yGEokuCEC0qmLuUlmleaBiace9KkBibQAHhDNJ4OTt0c3dH++ZLMx7LtncrwYTS5 06+G1DgKsUopzksVJ2lV+mgme4IQH0uv1lYqWX38UIYsO6d41j7acnzOjQfZE2EW V5K1H9Jb35A39qrUo6cPPal/YR1glKO413M53s8Ognbox9yxRkiMOuXNpBETU4Oo dnmWjByi0sAw5rB+/GBuS01shL9AREVeF+plAX1qH6fUenh8bOwx/xgNmSdt5dUM PLr3UHJqVfX8F/r33dEJ =HYcX -----END PGP SIGNATURE----- --LlyFhrrzptpgNMGs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140822153139.GN2737>