Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Jan 2018 13:35:13 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Gerald Pfeifer <gerald@pfeifer.com>
Cc:        Jan Beich <jbeich@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r457632 - in head/lang/guile2: . files
Message-ID:  <20180118133513.GA15166@FreeBSD.org>
In-Reply-To: <alpine.LSU.2.21.1801181323340.13743@anthias.pfeifer.com>
References:  <201712301912.vBUJCdtc086342@repo.freebsd.org> <1sjc-ylsz-wny@FreeBSD.org> <20171231084028.GA98479@FreeBSD.org> <r2rb-qnb5-wny@FreeBSD.org> <alpine.LSU.2.21.1801181323340.13743@anthias.pfeifer.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 18, 2018 at 01:26:55PM +0100, Gerald Pfeifer wrote:
> On Sun, 31 Dec 2017, Jan Beich wrote:
> >> How about this:
> >>
> >>     #if defined(__clang__) || (__GNUC__ * 10 + __GNUC_MINOR__ >= 46)
> >>     ... ?
> > Looks OK. None of lang/gcc* ports have __GNUC_MINOR__ >= 10.
> 
> GCC itself consistently uses
> 
>   __GNUC__ * 10000 + __GNUC_MINOR__ * 100 + __GNUC_PATCHLEVEL__
> 
> so this is what I'd go for (or omitting __GNUC_PATCH_LEVEL__, but
> using a factor of 100, not 10).

Yes, I was considering it, but using factor of 100 meant larger numbers
and also our COMPILER_VERSION uses factor of 10.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180118133513.GA15166>