Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Nov 2018 09:27:34 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Eugene Grosbein <eugen@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r341233 - head/usr.bin/trim
Message-ID:  <CANCZdfrPUEPh_vQURrSGHHN6KFN0r%2B31d-3ZHutx4MHC7T6vbg@mail.gmail.com>
In-Reply-To: <201811291449.wATEnXIY072818@repo.freebsd.org>
References:  <201811291449.wATEnXIY072818@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 29, 2018 at 7:49 AM Eugene Grosbein <eugen@freebsd.org> wrote:

> Author: eugen
> Date: Thu Nov 29 14:49:33 2018
> New Revision: 341233
> URL: https://svnweb.freebsd.org/changeset/base/341233
>
> Log:
>   trim(1): unbreak build after r341232 for platforms using gcc and not
> clang
>
>   MFC after:    1 month
>
> Modified:
>   head/usr.bin/trim/trim.c
>
> Modified: head/usr.bin/trim/trim.c
>
> ==============================================================================
> --- head/usr.bin/trim/trim.c    Thu Nov 29 14:21:26 2018        (r341232)
> +++ head/usr.bin/trim/trim.c    Thu Nov 29 14:49:33 2018        (r341233)
> @@ -42,8 +42,10 @@
>  #include <sysexits.h>
>  #include <unistd.h>
>
> +#ifndef lint
>  static const char rcsid[] =
>      "$FreeBSD$";
> +#endif /* not lint */
>

This is spelled FBSDID("$FreeBSD");

It's one of the many issues I have with the code. Should I just fix them?

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrPUEPh_vQURrSGHHN6KFN0r%2B31d-3ZHutx4MHC7T6vbg>