Date: Sat, 7 Apr 2007 20:28:25 +0400 From: Andrey Chernov <ache@FreeBSD.org> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Bruce Evans <bde@zeta.org.au> Subject: Re: cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h Message-ID: <20070407162825.GA10133@nagual.pp.ru> In-Reply-To: <20070407160401.GI63916@garage.freebsd.pl> References: <200704052110.l35LAsXH013966@repoman.freebsd.org> <20070406115326.A43678@delplex.bde.org> <20070407160401.GI63916@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 07, 2007 at 06:04:01PM +0200, Pawel Jakub Dawidek wrote: > Ok, I removed SEEK_DATA/SEEK_HOLE from stdio.h and hidden them in > sys/unistd.h under: >=20 > #if !defined(_POSIX_SOURCE) && !defined(_XOPEN_SOURCE) > [...] > #endif >=20 > This is consistent which what Solaris has. It is not enough. Currently you need !_C99_SOURCE !_ANSI_SOURCE=20 !_POSIX_C_SOURCE too (see the end of /sys/sys/cdefs.h) BTW, we design our *_VISIBLE framework right for the reason to _not_=20 mention all possible *_SOURCE each time but mention one *_VISIBLE=20 tag instead, so please follow the rules how rest of our includes are made. --=20 http://ache.pp.ru/ --AhhlLboLdkugWU4S Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGF8aoVg5YK5ZEdN0RAkWLAJ9tK9y+MWYxovQmVq3igxeq6VaUugCgpGOw HmEaOKxIJOZyBtdGIFZMey8= =0Nrc -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070407162825.GA10133>