Date: Fri, 20 Sep 2013 17:27:18 +0200 From: Pietro Cerutti <gahr@gahr.ch> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r327601 - head/Mk Message-ID: <3D05DDAC-CF76-4109-9182-6DDAD924CCC5@gahr.ch> In-Reply-To: <CAMHz58SSKvuXj%2B=3mXkZWuUL6VyOVee0s7%2BAeUOF5BhWNoVxUg@mail.gmail.com> References: <201309190805.r8J855cW009011@svn.freebsd.org> <CAMHz58SSKvuXj%2B=3mXkZWuUL6VyOVee0s7%2BAeUOF5BhWNoVxUg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20-set-2013, at 10:32, Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote= : > Hi Bapt, >=20 > May I suggest to change hard-coded sleep time to a settable variable defau= lts to 10? It would save time while checking multiple ports with terminal ou= tputs redirected to a log file. Definitely +1 > Thanks. >=20 > Regards, > sunpoet >=20 > On Thu, Sep 19, 2013 at 4:05 PM, Baptiste Daroussin <bapt@freebsd.org> wro= te: >> Author: bapt >> Date: Thu Sep 19 08:05:05 2013 >> New Revision: 327601 >> URL: http://svnweb.freebsd.org/changeset/ports/327601 >>=20 >> Log: >> Move the target for sanity checking to the end of bsd.port.mk so that >> WARNING and DEV_* can be defined anywhere >> While here, change sleep time from 5 to 10 so that users have time to r= ead it [1] >>=20 >> Suggested by: many [1] >>=20 >> Modified: >> head/Mk/bsd.port.mk >> head/Mk/bsd.sanity.mk >>=20 >> Modified: head/Mk/bsd.port.mk >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D >> --- head/Mk/bsd.port.mk Thu Sep 19 07:50:29 2013 (r327600) >> +++ head/Mk/bsd.port.mk Thu Sep 19 08:05:05 2013 (r327601) >> @@ -6491,6 +6491,43 @@ install-license: >> @${DO_NADA} >> .endif >>=20 >> +.if defined(WARNING) >> +show-warnings: >> + @${ECHO_MSG} "/!\\ WARNING /!\\" >> +.for m in ${WARNING} >> + @${ECHO_MSG} "${m}" >> +.endfor >> + @${ECHO_MSG} >> + @sleep 10 >> + >> +check-makefile:: show-warnings >> +.endif >> + >> +.if defined(DEVELOPER) >> +.if defined(DEV_WARNING) >> +show-dev-warnings: >> + @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile warnings, please consider= fixing /!\\" >> + @${ECHO_MSG} >> +.for m in ${DEV_WARNING} >> + @${ECHO_MSG} "${m}" >> +.endfor >> + @${ECHO_MSG} >> + @sleep 10 >> +check-makefile:: show-dev-warnings >> +.endif >> + >> +.if defined(DEV_ERROR) >> +show-dev-errors: >> + @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile errors /!\\" >> + @${ECHO_MSG} >> +.for m in ${DEV_WARNING} >> + @${ECHO_MSG} "${m}" >> +.endfor >> + @${ECHO_MSG} >> + @${FALSE} >> +check-makefile:: show-dev-errors >> +.endif >> +.endif #DVELOPER >> .endif >> # End of post-makefile section. >>=20 >>=20 >> Modified: head/Mk/bsd.sanity.mk >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D >> --- head/Mk/bsd.sanity.mk Thu Sep 19 07:50:29 2013 (r327600)= >> +++ head/Mk/bsd.sanity.mk Thu Sep 19 08:05:05 2013 (r327601)= >> @@ -91,41 +91,6 @@ DEV_WARNING+=3D "USE_GNOME=3Dltverhack is no >> DEV_WARNING+=3D "Please use the new format for LIB_DEPENDS, see handboo= k for details" >> .endif >>=20 >> -.if defined(WARNING) >> -show-warnings: >> -.for m in ${WARNING} >> - @${ECHO_MSG} "${m}" >> -.endfor >> - @sleep 5 >> - >> -check-makefile:: show-warnings >> -.endif >> - >> .if defined(_PREMKINCLUDED) >> DEV_ERROR+=3D "you cannot include bsd.port[.pre].mk twice" >> .endif >> - >> -.if defined(DEVELOPER) >> -.if defined(DEV_WARNING) >> -show-dev-warnings: >> - @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile warnings, please consider= fixing /!\\" >> - @${ECHO_MSG} >> -.for m in ${DEV_WARNING} >> - @${ECHO_MSG} "${m}" >> -.endfor >> - @${ECHO_MSG} >> - @sleep 5 >> -check-makefile:: show-dev-warnings >> -.endif >> - >> -.if defined(DEV_ERROR) >> -show-dev-errors: >> - @${ECHO_MSG} "/!\\ ${PKGNAME}: Makefile errors /!\\" >> - @${ECHO_MSG} >> -.for m in ${DEV_WARNING} >> - @${ECHO_MSG} "${m}" >> -.endfor >> - @${FALSE} >> -check-makefile:: show-dev-errors >> -.endif >> -.endif >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3D05DDAC-CF76-4109-9182-6DDAD924CCC5>