Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 18 May 2016 14:09:56 +0000 (UTC)
From:      Warner Losh <imp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r300146 - head/sys/boot/common
Message-ID:  <201605181409.u4IE9uYJ000273@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: imp
Date: Wed May 18 14:09:56 2016
New Revision: 300146
URL: https://svnweb.freebsd.org/changeset/base/300146

Log:
  Also add comment about the bug I comments in the forth.

Modified:
  head/sys/boot/common/commands.c

Modified: head/sys/boot/common/commands.c
==============================================================================
--- head/sys/boot/common/commands.c	Wed May 18 13:21:29 2016	(r300145)
+++ head/sys/boot/common/commands.c	Wed May 18 14:09:56 2016	(r300146)
@@ -211,6 +211,14 @@ command_help(int argc, char *argv[]) 
 
 COMMAND_SET(commandlist, "?", "list commands", command_commandlist);
 
+/*
+ * Please note: although we use the pager for the list of commands,
+ * this routine is called from the ? FORTH function which then
+ * unconditionally prints some commands. This will lead to anomalous
+ * behavior. There's no 'pager_output' binding to FORTH to allow
+ * things to work right, so I'm documenting the bug rather than
+ * fixnig it.
+ */
 static int
 command_commandlist(int argc, char *argv[])
 {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201605181409.u4IE9uYJ000273>