Date: Wed, 10 Sep 2014 18:19:25 -0400 From: Adam Weinberger <adamw@adamw.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Bryan Drewery <bdrewery@FreeBSD.org> Subject: Re: svn commit: r367883 - in head: Mk lang/gcc Message-ID: <38D5E5ED-9C3C-4868-BE12-D9EA877EE9EF@adamw.org> In-Reply-To: <alpine.LSU.2.11.1409102231390.2867@tuna.site> References: <201409101909.s8AJ9wpY028698@svn.freebsd.org> <5410AEB5.9050205@FreeBSD.org> <alpine.LSU.2.11.1409102231390.2867@tuna.site>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10 Sep, 2014, at 17:32, Gerald Pfeifer <gerald@pfeifer.com> wrote: > On Wed, 10 Sep 2014, Bryan Drewery wrote: >> Thanks for writing up a summary of changes. Very useful. I learned=20 >> about AddressSanitizer being supported. >=20 > You are very welcome! (I haven't tested AddressSanitizer myself,=20 > but think I recall a positive report by a user. If it does not=20 > work properly we might look into lang/gcc49 or lang/gcc5.) >=20 >=20 > On a related note, when trying to commit the PORTREVISION bump=20 > related to this commit, I ended up with: >=20 > svn: E165001: Commit failed (details follow): > svn: E165001: Commit blocked by pre-commit hook (exit code 1) with = output: > Do not commit ports with NOPORTDOCS or NOPORTEXAMPLES. > The port must be converted to proper OPTIONS. See > = http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile= -options.html >=20 > Not super helpful since it did not indicate which of the 1000+ ports=20= > actually failed this test. ;-) I could bypass this using Approved: > portmgr (implicit). The only remaining instances of NOPORTDOCS and NOPORTEXAMPLES are where = it is passed through MAKE_ENV or MAKE_ARGS to ports. Well, that and devel/rubygem-activesupport{,4} which mysteriously sets = NOPORTDOCS=3Dyes, but anything goes in ruby@ ports. The NOPORT* hooks could probably safely be altered not to match on = MAKE_{ENV,ARGS}. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?38D5E5ED-9C3C-4868-BE12-D9EA877EE9EF>