Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Aug 2016 06:10:10 +0000 (UTC)
From:      John Marino <marino@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r420960 - head/devel/distorm
Message-ID:  <201608270610.u7R6AAvE097496@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marino
Date: Sat Aug 27 06:10:10 2016
New Revision: 420960
URL: https://svnweb.freebsd.org/changeset/ports/420960

Log:
  devel/distorm: fix concurrent building
  
  For a reason I can't figure out, the "clean" target was being called
  simultaneously with the build target resulting in a possibility of
  deleting object files after they are built but before they are linked
  to make a library.
  
  The solution is to remove the "clean" target since it really serves no
  purpose in the ports framework (the work area starts clean).
  
  While here, join compound commands with "&&" rather than ";"

Modified:
  head/devel/distorm/Makefile

Modified: head/devel/distorm/Makefile
==============================================================================
--- head/devel/distorm/Makefile	Sat Aug 27 05:38:08 2016	(r420959)
+++ head/devel/distorm/Makefile	Sat Aug 27 06:10:10 2016	(r420960)
@@ -73,10 +73,10 @@ post-install:
 
 .else
 do-build:
-	@(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} \
+	@(cd ${BUILD_WRKSRC} && ${SETENV} ${MAKE_ENV} \
 	EXTRAFLAGS="${PICFLAG} -DDISTORM_DYNAMIC" ${MAKE} ${_MAKE_JOBS} \
-	${MAKE_ARGS} clib clean)
-	@(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} \
+	${MAKE_ARGS} clib)
+	@(cd ${BUILD_WRKSRC} && ${SETENV} ${MAKE_ENV} \
 	EXTRAFLAGS="-DDISTORM_STATIC" ${MAKE} ${_MAKE_JOBS} ${MAKE_ARGS} staticlib)
 	${CC} ${CFLAGS} ${LDFLAGS} -o ${BUILD_WRKSRC}/disasm \
 	${WRKSRC}/examples/linux/main.c ${BUILD_WRKSRC}/libdistorm3.a



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201608270610.u7R6AAvE097496>