Date: Sat, 6 Aug 2016 13:13:12 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: Mathieu Arnold <mat@FreeBSD.org>, Pawel Pekala <pawel@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r419716 - in head/games: . zdoom Message-ID: <20160806111312.mafbvw4hob3a6x5l@ivaldir.etoilebsd.net> In-Reply-To: <20160806075510.GA64469@FreeBSD.org> References: <201608052308.u75N8bQf092339@repo.freebsd.org> <02F62285C025519217DB3167@atuin.in.mat.cc> <20160806073604.GD53097@FreeBSD.org> <3DA12F22975D816013905296@atuin.in.mat.cc> <20160806075510.GA64469@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ggqu2k4i5epxkmhb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Sat, Aug 06, 2016 at 07:55:10AM +0000, Alexey Dokuchaev wrote:
> On Sat, Aug 06, 2016 at 09:38:30AM +0200, Mathieu Arnold wrote:
> > +--On 6 ao??t 2016 07:36:04 +0000 Alexey Dokuchaev <danfe@FreeBSD.org>
> > |=20
> > | Why? Now it looks inconsistent:
> > |=20
> > | % make -V PLIST_FILES
> > | bin/zdoom /usr/local/share/zdoom/zdoom.pk3
> > |=20
> > | If your point was to avoid plist substitutions for some reason (if th=
ey do
> > | not work in PLIST_FILES it looks like a bug that should be fixed inst=
ead),
> > | ${DATADIR_REL} still suits better.
> >=20
> > Substitutions are there for one reason only, to be able to carry variab=
les
> > from the Makefile to the pkg-plist file.
>=20
> Ah right, ignore what I said about a bug that should be fixed. :-/
>=20
> > DATADIR is just fine, it is the full path to the file, which is support=
ed.
>=20
> Except that it looks inconsistent and ugly. Mixing relative and absolute
> paths might also be error-prone.
Actually it is less error prone to have absolute path (but less consistent)
because it will avoid issues we already had a lot in the path when someone =
badly
uses '@cwd' without resetting it and PLIST_FILES ends up being appended aft=
er
that.
Bapt
--ggqu2k4i5epxkmhb
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCAAGBQJXpcZHAAoJEGOJi9zxtz5aI/YQANViEmhi064heTrreKsQ9CwQ
Ts4XDQ4JVPIX3LY1wEZIxJ8CyD3JWCbXFLANiE5cbLe3DP9xLy9Oqwl+JA/iKT38
hxVM+SKmj7cosEELkU9ZViqnoDSOnUphBF81o1t9/u4sRlB+FfvjPZtjpL1Ynneq
FiOR2du4D9cfi9G+7AIB4AkfSzZ0mppaGuRFCWNoRBvnOiKb5YKvPzET4SdNot+v
Hsh7NmXN8ykv35sXAoTkeasExvQM1DrnsvY3ywWaayXoVO5nLbnQ7A103XS1Pq9+
4AI/uDPCU/ZVnvy16qH4YZeIpu1sguDAS82sTWEfCH91IaiSz85R6HtQqifbJo2I
sa37RgYlPDq22knEvaDHpSZ1pWWn49TQtRll+VvJ9gHkeT9rjB1+8qiaj90c1Bzu
fEtnZm81lguRCNZf6KfHjepezPASTl+fvFNLS4PqaO6b2lx2/i70GU1MSIBCVc1v
iEeqmc56Pg6d2gR2vdXtyr3s6bDwOSB+/xnhv9r7fdt/5Bin3aeEPEFHY84kBTFt
vZQT67eSuvmK2ww+5FhOm4R2uaBqn/dgbFOOB/NWxqx8BlaGk3lJxCwoltF1baLi
cRWPN6GV1h/+waw0LjfA/QpwuS4AvCzAjliKJzqFB/sysrBRWwZHLWJXakjfm1RR
9PkzEkW1zd4uzPgWYrZQ
=Dj8j
-----END PGP SIGNATURE-----
--ggqu2k4i5epxkmhb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160806111312.mafbvw4hob3a6x5l>