Date: Sun, 4 May 1997 11:50:01 -0700 (PDT) From: dwmalone@maths.tcd.ie To: freebsd-bugs Subject: Re: kern/2635: NFS cache doesn't check execute permission on directori Message-ID: <199705041850.LAA10101@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/2635; it has been noted by GNATS.
From: dwmalone@maths.tcd.ie
To: freebsd-gnats-submit@freebsd.org, dwmalone@maths.tcd.ie
Cc: Subject: Re: kern/2635: NFS cache doesn't check execute permission on directori
Date: Sun, 4 May 97 19:46:25 +0100
I've been using the patch which I submitted for 3 months
now on both 2.1.7.1 and 2.2.1 machines with no problems
that seem to be related to it. I checked the current
source today, and it looks like the problem has not
been fixed by the lite2 merge or any of the work that
has gone on.
I guess anyone that knows the vfs stuff well should be
able to review the patch quite quickly.
David.
>*** /FreeBSD/FreeBSD-2.2/src/sys/nfs/nfs_vnops.c Wed Jan 8 23:50:18 199
>7
>--- ./nfs_vnops.c Sat Feb 1 23:10:53 1997
>***************
>*** 840,845 ****
>--- 840,849 ----
> if ((error = cache_lookup(dvp, vpp, cnp)) && error != ENOENT) {
> struct vattr vattr;
> int vpid;
>+
>+ if (error=VOP_ACCESS(dvp,VEXEC,cnp->cn_cred,cnp->cn_proc)
>) {
>+ return (error);
>+ }
>
> newvp = *vpp;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199705041850.LAA10101>