Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 8 Apr 2017 09:49:21 +0000 (UTC)
From:      Kristof Provost <kp@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r316641 - stable/10/sys/netpfil/pf
Message-ID:  <201704080949.v389nL0r074780@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kp
Date: Sat Apr  8 09:49:21 2017
New Revision: 316641
URL: https://svnweb.freebsd.org/changeset/base/316641

Log:
  MFC r316355
  
  pf: Fix leak of pf_state_keys
  
  If we hit the state limit we returned from pf_create_state() without cleaning
  up.
  
  PR:		217997
  Submitted by:	Max <maximos@als.nnov.ru>

Modified:
  stable/10/sys/netpfil/pf/pf.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/netpfil/pf/pf.c
==============================================================================
--- stable/10/sys/netpfil/pf/pf.c	Sat Apr  8 09:48:21 2017	(r316640)
+++ stable/10/sys/netpfil/pf/pf.c	Sat Apr  8 09:49:21 2017	(r316641)
@@ -3522,7 +3522,7 @@ pf_create_state(struct pf_rule *r, struc
 	    (counter_u64_fetch(r->states_cur) >= r->max_states)) {
 		counter_u64_add(V_pf_status.lcounters[LCNT_STATES], 1);
 		REASON_SET(&reason, PFRES_MAXSTATES);
-		return (PF_DROP);
+		goto csfailed;
 	}
 	/* src node for filter rule */
 	if ((r->rule_flag & PFRULE_SRCTRACK ||



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704080949.v389nL0r074780>