Date: Wed, 18 May 2016 10:11:58 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r300098 - head/usr.sbin/makefs Message-ID: <88775237-2a05-4c6f-5c15-0b7a19ce6d46@FreeBSD.org> In-Reply-To: <CAPyFy2BynX3EKiKCpFVjGNR3jypFu=3bACTcMeQ-5W%2BifiadKg@mail.gmail.com> References: <201605180022.u4I0MqSU048808@repo.freebsd.org> <CAPyFy2BynX3EKiKCpFVjGNR3jypFu=3bACTcMeQ-5W%2BifiadKg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 05/17/16 20:12, Ed Maste wrote: > On 18 May 2016 at 00:22, Pedro F. Giffuni <pfg@freebsd.org> wrote: >> Author: pfg >> Date: Wed May 18 00:22:52 2016 >> New Revision: 300098 >> URL: https://svnweb.freebsd.org/changeset/base/300098 >> >> Log: >> makefs(8): Clarify the comment concerning seeding. >> >> Avoid giving the impression makefs currently supports reproduceable >> builds. > > Thanks! > > It might make sense to seed based on SOURCE_DATE_EPOCH > (https://reproducible-builds.org/specs/source-date-epoch/) if set, and > later on we ought to add an option to set the seed on the command > line. > Interesting. FWIW, NetBSD did some other changes but they basically removed the seeding which may be mildly dangerous in this case (makefs uses random() in other places without seeding). > But, there are a lot of other reproducible build tasks that are > probably more important to tackle before this. > Yes, I am not really very interested in reproducible builds but this is one of the cases where we cannot go blindly replacing random() with arc4random(). Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?88775237-2a05-4c6f-5c15-0b7a19ce6d46>