Date: Mon, 04 Apr 2011 03:45:26 -0500 From: Zhihao Yuan <lichray@gmail.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/156171: port multimedia/mplayer patch-libao2-ao_oss.c is incorrect Message-ID: <4d99852b.9aa5e70a.3dd0.ffffeb8c@mx.google.com> Resent-Message-ID: <201104040850.p348o3XN001340@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 156171 >Category: ports >Synopsis: port multimedia/mplayer patch-libao2-ao_oss.c is incorrect >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Mon Apr 04 08:50:03 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Zhihao Yuan >Release: FreeBSD 8.2-STABLE amd64 >Organization: Northern Illinois University >Environment: System: FreeBSD compaq.yuetime 8.2-STABLE FreeBSD 8.2-STABLE #0: Mon Mar 14 02:51:28 CDT 2011 root@compaq.yuetime:/usr/obj/usr/src/sys/HOUKAGO amd64 >Description: This patch moves the samplerate setting clause out of a condition block, which intends to make sure the samplerate is always set. But actually, there is another condition block at line 452, which makes these two blocks mutual exclusive. So, this patch is no needed. But! The author has reason to write the conditions like this! According to 4Front's document, http://www.4front-tech.com/pguide/audio.html the SNDCTLs must be set in this order: format, channels, sampling rate. So, this patch is incorrect. >How-To-Repeat: >Fix: Since the patch is unneeded and incorrect, please remove it. >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4d99852b.9aa5e70a.3dd0.ffffeb8c>