Date: Sat, 13 Sep 2014 18:22:32 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193614] New: [maintainer] update port: www/libevhtp 8.4-RELEASE breakage Message-ID: <bug-193614-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193614 Bug ID: 193614 Summary: [maintainer] update port: www/libevhtp 8.4-RELEASE breakage Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Only Me Priority: --- Component: Infrastructure Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: yan_jingfeng@yahoo.com Created attachment 147278 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147278&action=edit SVN diff same 146878 content, but load from file, not paste Last commit intends to add sys/types.h for FreeBSD 8.4. However, the trick is over-played. "#ifdef SO_ACCEPT... " location of the patch file has problem, which causes the sys/types is not included finally. In the original test patch on 8.4, #ifdef SO_ACCEPTFILTER is placed at the end of #include section. This helps to pass the test because SO_ACCEPTFILTER is defined in sys/socket.h and the socket.h is included before. In such case, sys/types.h is included. When committing and generate the diff for SVN, I adjust its location. When #ifdef SO_ACCEPTFILTER listed before socket.h, this test return false. Then, the types.h will not included. Overall, it is not necessary to use this test, and sys/types.h can be include more blindly. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193614-13>