Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 30 Sep 2006 23:33:35 +0900
From:      Hajimu UMEMOTO <ume@FreeBSD.org>
To:        John Hay <jhay@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/netinet6 nd6.c
Message-ID:  <ygewt7l1l1c.wl%ume@mahoroba.org>
In-Reply-To: <200609301408.k8UE8vpM069161@repoman.freebsd.org>
References:  <200609301408.k8UE8vpM069161@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,

>>>>> On Sat, 30 Sep 2006 14:08:57 +0000 (UTC)
>>>>> John Hay <jhay@FreeBSD.org> said:

jhay> jhay        2006-09-30 14:08:57 UTC

jhay>   FreeBSD src repository

jhay>   Modified files:
jhay>     sys/netinet6         nd6.c 
jhay>   Log:
jhay>   My previous commit broke "route add -inet6 <network_addr> -interface gif0".
jhay>   Fix that by excluding point-to-point interfaces.
  
> -		} else if (req == RTM_ADD && SDL(gate)->sdl_alen == 0) {
> +		} else if (req == RTM_ADD && SDL(gate)->sdl_alen == 0 &&
> +		    (ifp->if_flags & (IFF_POINTOPOINT | IFF_LOOPBACK)) == 0) {
> 			ln->ln_state = ND6_LLINFO_INCOMPLETE;

Umm, it seems still there is a problem.  We are using -interface not
only for point-to-point interface and loopback.
I'm not sure but can we check `(rt->rt_flags & RTF_HOST) != 0', here?

Sincerely,

--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org  ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ygewt7l1l1c.wl%ume>