Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Jun 2010 20:51:56 +0000 (UTC)
From:      Rui Paulo <rpaulo@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r208851 - stable/8/sys/net80211
Message-ID:  <201006052051.o55Kpu8K034556@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rpaulo
Date: Sat Jun  5 20:51:56 2010
New Revision: 208851
URL: http://svn.freebsd.org/changeset/base/208851

Log:
  MFC r208696:
   Don't reference null pointer in hwmp_recv_preq().
  
   Found with:	Coverity Prevent(tm)
   CID:		3912
  Approved by:	re (bz)

Modified:
  stable/8/sys/net80211/ieee80211_hwmp.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)
  stable/8/sys/dev/xen/xenpci/   (props changed)
  stable/8/sys/geom/sched/   (props changed)

Modified: stable/8/sys/net80211/ieee80211_hwmp.c
==============================================================================
--- stable/8/sys/net80211/ieee80211_hwmp.c	Sat Jun  5 20:41:22 2010	(r208850)
+++ stable/8/sys/net80211/ieee80211_hwmp.c	Sat Jun  5 20:51:56 2010	(r208851)
@@ -707,6 +707,9 @@ hwmp_recv_preq(struct ieee80211vap *vap,
 	rtorig = ieee80211_mesh_rt_find(vap, preq->preq_origaddr);
 	if (rtorig == NULL)
 		rtorig = ieee80211_mesh_rt_add(vap, preq->preq_origaddr);
+	if (rtorig == NULL)
+		/* XXX stat */
+		return;
 	hrorig = IEEE80211_MESH_ROUTE_PRIV(rtorig, struct ieee80211_hwmp_route);
 	/*
 	 * Sequence number validation.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006052051.o55Kpu8K034556>