Date: Tue, 27 Jan 1998 21:41:32 -0500 From: Matt Thomas <matt@3am-software.com> To: Stephen McKay <syssgm@dtir.qld.gov.au> Cc: freebsd-current@FreeBSD.ORG Subject: Re: PATCH: if_de.c #ifdef based version encoding Message-ID: <199801280243.VAA17410@tecumseh.altavista-software.com> In-Reply-To: <199801280124.LAA06212@ogre.dtir.qld.gov.au> References: <34CE4438.15FB7483@whistle.com> <199801271101.DAA25275@implode.root.com> <34CE4438.15FB7483@whistle.com>
next in thread | previous in thread | raw e-mail | index | archive | help
>>> In theory, the de driver is maintained by Matt Thomas and he supports >>> multiple OS's and OS versions in the code. You'll notice that there are >>> #ifdef's for NetBSD and BSD/OS in there as well. If we were going to do >>> as you suggest, then it would only make sense if all of the OS #ifdef's >>> were removed. This will only make it more difficult for Matt to support >>> FreeBSD, so I think it's a bad idea. > >Making Matt's life difficult would be counterproductive, but these version >tests are pretty silly from an ivory tower purist view, and are also a pain >in practice. I'm with Terry on this one. If there is such a symbol on 2.1.0 or later I'll use it. -- Matt Thomas Internet: matt@3am-software.com 3am Software Foundry WWW URL: http://www.3am-software.com/bio/matt/ Nashua, NH Disclaimer: I disavow all knowledge of this message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199801280243.VAA17410>