Date: Mon, 16 May 2016 15:08:52 -0700 From: Adrian Chadd <adrian.chadd@gmail.com> To: Andriy Voskoboinyk <avos@freebsd.org> Cc: Don Lewis <truckman@freebsd.org>, "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org> Subject: Re: minor array overflow in ifconfig set80211chanlist() Message-ID: <CAJ-Vmok4wxOzQz=kanC70P3OU_0hCy=rcY3jHYoJ5-GtahTLyQ@mail.gmail.com> In-Reply-To: <op.yhksz7c44dikkl@localhost> References: <201605162142.u4GLgs8d072880@gw.catspoiler.org> <op.yhkssoeniew4ia@localhost> <CAJ-VmokTDO9=ZX5rGT1ZtW2aBEvzB_EVpEZvL7crs-KrQmqVMA@mail.gmail.com> <op.yhksz7c44dikkl@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 May 2016 at 15:05, Andriy Voskoboinyk <avos@freebsd.org> wrote: > Tue, 17 May 2016 01:03:03 +0300 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Adrian Chadd > <adrian.chadd@gmail.com>: > >> Heh, god, it's used for both maximum ieee channel number /and/ the >> array size? we should eventually fix that; 11ac channels will likely >> overflow all of the above. :( > > > No (yes) :) > I mean ic->ic_nchans and nitems(ic->ic_channels) > ... but you are right: ic_ieee is uint8_t, so it's limited by this number > too. Right. Well, for 11ac they still have the IEEE number, but they also have separate frequency definitions in the IEs for upper/lower 80MHz and the configuration therein. -adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmok4wxOzQz=kanC70P3OU_0hCy=rcY3jHYoJ5-GtahTLyQ>