Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 May 2021 20:41:55 -0500
From:      Eric van Gyzen <eric@vangyzen.net>
To:        Ravi Pokala <rpokala@freebsd.org>, Eric van Gyzen <vangyzen@FreeBSD.org>,  src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: ee8b757a949a - main - ipmi: support getting address from EFI
Message-ID:  <7c68e6f9-29c4-71a6-c172-465fc8dda9e3@vangyzen.net>
In-Reply-To: <A368B21B-BF91-4F83-892A-0D1ACF2560B2@panasas.com>
References:  <202104291525.13TFPCQR020414@gitrepo.freebsd.org> <A368B21B-BF91-4F83-892A-0D1ACF2560B2@panasas.com>

next in thread | previous in thread | raw e-mail | index | archive | help
>      URL: https://cgit.FreeBSD.org/src/commit/?id=ee8b757a949a9575c7355ea01f0475e0c526b9e5
> 
>      commit ee8b757a949a9575c7355ea01f0475e0c526b9e5
> 
>          ipmi: support getting address from EFI
> 
> I get why the MODULE_DEPEND() was added to ipmi_smbios.c: it's now making an efirt call. But why was it added to the other three files?

Those other files call the function that calls into efirt.  I don’t know 
if the explicit dependencies were actually necessary, but since they’re 
logically correct, I figure they don’t hurt.

Eric



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7c68e6f9-29c4-71a6-c172-465fc8dda9e3>