Date: Wed, 29 Mar 2017 23:48:17 -0400 From: Johannes M Dieterich <jmd@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: Matthew Rezny <rezny@freebsd.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, owner-ports-committers@freebsd.org Subject: Re: svn commit: r437215 - in head/graphics: gbm libEGL libGL libglapi Message-ID: <6a245317c900f4cf092bcdf70c1798ee@freebsd.org> In-Reply-To: <8tnn-5tcs-wny@FreeBSD.org> References: <201703291657.v2TGvrpM076369@repo.freebsd.org> <h92c-ezt0-wny@FreeBSD.org> <1824022.AbFPd1OJUh@workstation.reztek> <8tnn-5tcs-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2017-03-29 23:36, Jan Beich wrote:
> Matthew Rezny <rezny@freebsd.org> writes:
>
>> On Wednesday 29 March 2017 19:51:55 Jan Beich wrote:
>>
>>> Matthew Rezny <rezny@FreeBSD.org> writes:
>>> > - @${REINPLACE_CMD} -e 's|x86_64|amd64|' \
>>> > + @${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[:space:]* //|' \
>>>
>>> [:space:] is invalid character class thus treated as a list of
>>> characters.
>>> \S corresponds to [^[:space:]], while \s to [[:space:]].
>>>
>>> $ man pcrepattern | col -b | fgrep -m1 \\S
>>> \S any character that is not a white space character
>>>
>>> This may break build given -march, etc. are no longer stripped.
>>
>> I wish that information had been presented when I said "I guess it
>> should have
>> been [:space:] instead of [:graph:] in the replacement." after you
>> stated
>> [:graph:] was plain incorrect, although it is what had been previously
>> suggested to me and did seem to be working.
>
> I didn't focus on pointing out every mistake with the existing hack
> because it was soon going away. Now that devel/libclc depends on llvm40
> the original motivation to hold out on 17.* (bug 217016) before 2017Q2
> has been weakened.
Also, there is a review for 17.0.2 up by me:
https://reviews.freebsd.org/D9469 which changes the default LLVM version
to 4.0 as newer AMD GPUs need that and uses libudev-devd now. Comments
welcome!
Please note that after today's commits the patch will not apply cleanly
anymore, I'll update.
>> To be sure there is no misunderstanding now, would you consider this
>> correct?
>> @${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[^[:space:]]*
>> //|' \
>
> Not quite, adding extra space after [] is unnecessary.
>
> -e 's|\\S\*|[^[:space:]]*|' \
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a245317c900f4cf092bcdf70c1798ee>