Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 27 Jul 2017 16:23:12 +0200 (CEST)
From:      =?ISO-8859-1?Q?Trond_Endrest=F8l?= <Trond.Endrestol@fagskolen.gjovik.no>
To:        FreeBSD stable <freebsd-stable@freebsd.org>
Subject:   Re: r321601 causes make buildworld to fail on stable/11
Message-ID:  <alpine.BSF.2.21.1707271622170.53090@mail.fig.ol.no>
In-Reply-To: <alpine.BSF.2.21.1707271301520.53090@mail.fig.ol.no>
References:  <alpine.BSF.2.21.1707271129500.53090@mail.fig.ol.no> <4d589d27-8546-51f5-d7d6-50736eb7534b@zyxst.net> <alpine.BSF.2.21.1707271301520.53090@mail.fig.ol.no>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 27 Jul 2017 13:03+0200, Trond Endrestøl wrote:

> On Thu, 27 Jul 2017 11:57+0100, tech-lists wrote:
> 
> > On 27/07/2017 10:33, Trond Endrestøl wrote:
> > > r321601 gives me these error messages on stable/11:
> > > 
> > > /usr/src/usr.sbin/acpi/acpidump/acpi.c:1089:6: error: use of undeclared identifier 'ACPI_SRAT_TYPE_GIC_ITS_AFFINITY'; did you mean 'ACPI_SRAT_TYPE_GICC_AFFINITY'?
> > >     [ACPI_SRAT_TYPE_GIC_ITS_AFFINITY] = "GIC ITS",
> > >      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >      ACPI_SRAT_TYPE_GICC_AFFINITY
> > > /usr/src/sys/contrib/dev/acpica/include/actbl1.h:1504:5: note: 'ACPI_SRAT_TYPE_GICC_AFFINITY' declared here
> > >     ACPI_SRAT_TYPE_GICC_AFFINITY        = 3,
> > >     ^
> > > /usr/src/usr.sbin/acpi/acpidump/acpi.c:1089:41: error: initializer overrides prior initialization of this subobject [-Werror,-Winitializer-overrides]
> > >     [ACPI_SRAT_TYPE_GIC_ITS_AFFINITY] = "GIC ITS",
> > >                                         ^~~~~~~~~
> > > /usr/src/usr.sbin/acpi/acpidump/acpi.c:1088:38: note: previous initialization is here
> > >     [ACPI_SRAT_TYPE_GICC_AFFINITY] = "GICC",
> > >                                      ^~~~~~
> > > 
> > > Am I missing something? Am acpi.c missing something?
> > > 
> > 
> > I see this as well on r321611
> 
> r321600 builds fine.
> r321601 does not, and must be amended or reverted.

r321619 builds fine. Thank you, Ed M.

-- 
Trond.
From owner-freebsd-stable@freebsd.org  Thu Jul 27 15:07:13 2017
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 074C1DCD024
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Thu, 27 Jul 2017 15:07:13 +0000 (UTC)
 (envelope-from eugen@grosbein.net)
Received: from hz.grosbein.net (hz.grosbein.net [78.47.246.247])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 948607D91E;
 Thu, 27 Jul 2017 15:07:11 +0000 (UTC)
 (envelope-from eugen@grosbein.net)
Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221])
 by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id v6RF71Qt080486
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
 Thu, 27 Jul 2017 17:07:02 +0200 (CEST)
 (envelope-from eugen@grosbein.net)
X-Envelope-From: eugen@grosbein.net
X-Envelope-To: freebsd-stable@FreeBSD.org
Received: from eg.sd.rdtc.ru (eugen@localhost [127.0.0.1])
 by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTP id v6RF6rZs083059;
 Thu, 27 Jul 2017 22:06:53 +0700 (+07)
 (envelope-from eugen@grosbein.net)
To: FreeBSD Stable <freebsd-stable@FreeBSD.org>
Cc: Konstantin Belousov <kib@freebsd.org>
From: Eugene Grosbein <eugen@grosbein.net>
Subject: stable/11 regression: SIGSYS in the /bin/sh
X-Enigmail-Draft-Status: N1110
Message-ID: <597A018D.4040601@grosbein.net>
Date: Thu, 27 Jul 2017 22:06:53 +0700
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=3.6 required=5.0 tests=BAYES_00, DATE_IN_FUTURE_96_Q, 
 LOCAL_FROM autolearn=no autolearn_force=no version=3.4.1
X-Spam-Report: * 3.3 DATE_IN_FUTURE_96_Q Date: is 4 days to 4 months after
 Received: date
 * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1%
 *      [score: 0.0000] *  2.6 LOCAL_FROM From my domains
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on hz.grosbein.net
X-Spam-Level: ***
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>;
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Jul 2017 15:07:13 -0000

Hi!

Very recently stable/11 got a problem somewhere between r321073 and r321459:
/bin/sh crashes with SIGSYS at boot time:

Trying to mount root from ufs:/dev/ada0s1a [ro]...
start_init: trying /sbin/init
ppid 21 (sh), uid 0: exited on signal 12
id 21 comm sh: nosys 42
Jul 27 14:30:23 init: /bin/sh on /etc/rc terminated abnormally, going to single user mode

This is *not* upgrade but complete rebuild of NanoBSD image:
all binaries, libraries and kernel are built from stable/11 sources.

My custom kernel for amd64 has COMPAT_43TTY and COMPAT_FREEBSD32 options
and no other COMPAT_XXX options. It has no COMPAT_FREEBSD10 option too
as this is new installation.

Also, I needed the following patch to make sysctl kern.lognosys
work for non-tty case:

--- sys/kern/subr_prf.c.orig     2017-07-25 15:14:27.236304000 +0700
+++ sys/kern/subr_prf.c  2017-07-27 21:05:55.912042000 +0700
@@ -958,6 +958,7 @@ number:
                        break;
                }
        }
+       return (retval);
 #undef PCHAR
 }
 
--- sys/kern/kern_sig.c.orig     2017-07-25 15:14:27.232126000 +0700
+++ sys/kern/kern_sig.c  2017-07-27 21:07:58.298440000 +0700
@@ -3596,7 +3596,9 @@
        tdsignal(td, SIGSYS);
        PROC_UNLOCK(p);
        if (kern_lognosys)
-               uprintf("pid %d comm %s: nosys %d\n", p->p_pid, p->p_comm,
+               if (!uprintf("pid %d comm %s: nosys %d\n", p->p_pid, p->p_comm,
+                   td->td_sa.code))
+                 printf("pid %d comm %s: nosys %d\n", p->p_pid, p->p_comm,
                    td->td_sa.code);
        return (ENOSYS);
 }


Please take a look.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.21.1707271622170.53090>