Date: Fri, 25 Mar 2016 18:51:10 +0100 From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: John Marino <freebsd.contact@marino.st> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, marino@freebsd.org Subject: Re: svn commit: r411863 - head/graphics/digikam-kde4 Message-ID: <86egayla41.fsf@FreeBSD.org> In-Reply-To: <56F567E5.4090905@marino.st> (John Marino's message of "Fri, 25 Mar 2016 17:31:33 %2B0100") References: <201603251629.u2PGTHEF009723@repo.freebsd.org> <56F567E5.4090905@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
John Marino <freebsd.contact@marino.st> writes: > On 3/25/2016 5:29 PM, Raphael Kubo da Costa wrote: >> Author: rakuco >> Date: Fri Mar 25 16:29:17 2016 >> New Revision: 411863 >> URL: https://svnweb.freebsd.org/changeset/ports/411863 >> >> Log: >> Add USES=compiler:c++11-lang. >> >> This fixes digikam-kde4's build on 9.3 after the graphics/lensfun update in >> r411373. >> >> lensfun.h includes C++ code (class and template declarations) inside an >> extern "C" block that causes base GCC to fail: > > Not anymore. I patched it out yesterday (patch from upstream). Are you sure > it wasn't building on 9.3 already after my change? I took the pkg-fallout emails at face value and only tested the port on 9.3 after adding USES=compiler:c++11-lang, so it is possible that I can revert this change indeed. However, the last commit to graphics/lensfun was r411373 from March 18th. Should I be looking elsewhere for your commit?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86egayla41.fsf>