Date: Tue, 10 Aug 2021 09:44:10 +0000 From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 257692] [NEW PORT] x11/xfce4-docklike-plugin A modern, minimalist taskbar for Xfce Message-ID: <bug-257692-28711-8nlPvUI0vZ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-257692-28711@https.bugs.freebsd.org/bugzilla/> References: <bug-257692-28711@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D257692 --- Comment #8 from Guido Falsi <madpilot@FreeBSD.org> --- (In reply to Quentin Baker from comment #7) In the while I noticed some issues by skimming you submission patch: instead of doing: DISTVERSION=3D v0.3.0 you should use: PORTVERSION=3D 0.3.0 DISTVERSIONPREFIX=3D v This could also help with gitlab. Another issue, usually lib depends are distributed one per line like this: LIB_DEPENDS=3D libinotify.so:devel/libinotify \ libharfbuzz.so:print/harfbuzz USES and _USE lines content should be sorted The pkg-descr should be expanded. It makes little sense to have the same te= xt in the port COMMENT (which requires a very succinct description) and the pkg-descr which should expand on what the software actually does. Could you rewrite the pkg-descr with a more thorough description? You can also copy it from upstream, but it has to be something more than the COMMENT content. Also I have some perplexity about the LDFLAGS you added, maybe a patch to t= he Makefile or configure script would be better, but for this last one testing= is needed to decide the best solution. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-257692-28711-8nlPvUI0vZ>