Date: Thu, 24 May 2018 07:23:53 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r334129 - head/sys/amd64/conf Message-ID: <201805241423.w4OENrjU040655@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <CAPyFy2AcDG57FCfRErCRdvpAAWSrkZO6mdfgioY_Sj1owmXhBw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 24 May 2018 at 01:36, Matthew Macy <mmacy@freebsd.org> wrote: > > On Wed, May 23, 2018 at 10:32 PM, Ravi Pokala <rpokala@freebsd.org> wrote: > >>> > >>> Author: mmacy > >>> Date: Thu May 24 04:31:53 2018 > >>> New Revision: 334129 > >>> URL: https://svnweb.freebsd.org/changeset/base/334129 > >>> > >>> Log: > >>> take NUMA out > >>> ... > >> Why? > > > > > > I ^C'd the prior commit too late. > > For cases like this the commit message should include something like > "It was accidentally committed in r334128." Would it not make some sense to revert and recommit when these happen, especially if there is an intenent to MFC, otherwise one has to be sure to merge both parts to end up with a corrected commit to stable/ We seem to be afraid of revert, recommit correcting cycles, and in the long run that may be causing us some problems. Just a though. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201805241423.w4OENrjU040655>