Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Dec 2003 05:30:46 -0800 (PST)
From:      Juli Mallett <jmallett@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 44447 for review
Message-ID:  <200312281330.hBSDUkUZ041128@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=44447

Change 44447 by jmallett@jmallett_oingo on 2003/12/28 05:30:15

	Maybe dirty PTEs coming in TLBMod is OK after all...

Affected files ...

.. //depot/projects/mips/sys/mips/mips/tlb.c#17 edit

Differences ...

==== //depot/projects/mips/sys/mips/mips/tlb.c#17 (text+ko) ====

@@ -237,8 +237,19 @@
 		panic("write to invalid page");
 	if (pte_ro(pte))
 		panic("write to ro page");
+
+ 	/*
+	 * XXX I don't like these, but it looks like the fact of the
+	 * matter is that they happen, for example I have something in
+	 * front of me right now where the even side of the buffer is
+	 * dirty, and so is the odd side, but in the buffer, the left
+	 * side is marked, and there's some reason why a reload didn't
+	 * happen, so just let it go... let it go...
+	 */
+#if 0
 	if (pte_dirty(pte))
 		panic("dirty page caused a TLBMod");
+#endif
 
 	/*
 	 * Mark the page dirty.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200312281330.hBSDUkUZ041128>