Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 3 Aug 2009 16:19:59 GMT
From:      Marta Carbone <marta@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 166968 for review
Message-ID:  <200908031619.n73GJxOx064807@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=166968

Change 166968 by marta@marta_onelab1 on 2009/08/03 16:19:02

	The ipfw_chk() which contains a huge switch statement with one block
	per microinstruction was substituted with a table of functions, one
	function for each microinstruction.
	
	Labels and goto across the big switch was removed, the pullup_to macro
	has been converted to a function.

Affected files ...

.. //depot/projects/soc2009/marta_ipfw/src/sbin/ipfw/Makefile#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sbin/ipfw/altq.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sbin/ipfw/dummynet.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sbin/ipfw/ipfw.8#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sbin/ipfw/ipfw2.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sbin/ipfw/ipfw2.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sbin/ipfw/ipv6.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sbin/ipfw/main.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sbin/ipfw/nat.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/accf_data.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/accf_dns.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/accf_http.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/icmp6.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/icmp_var.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/if_atm.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/if_atm.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/if_ether.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/if_ether.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/igmp.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/igmp.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/igmp_var.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in_cksum.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in_gif.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in_gif.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in_mcast.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in_pcb.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in_pcb.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in_proto.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in_rmx.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in_systm.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/in_var.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip6.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_carp.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_carp.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_divert.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_divert.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_dummynet.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_ecn.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_ecn.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_encap.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_encap.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_fastfwd.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_fw.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_gre.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_gre.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_icmp.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_icmp.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_id.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_input.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_ipsec.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_ipsec.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_mroute.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_mroute.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_options.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_options.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_output.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ip_var.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ipfw/ip_dummynet.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ipfw/ip_fw2.c#1 add
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ipfw/ip_fw_nat.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/ipfw/ip_fw_pfil.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/HISTORY#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_cuseeme.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_db.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_dummy.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_ftp.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_irc.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_local.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_mod.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_mod.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_nbt.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_pptp.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_proxy.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_sctp.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_sctp.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_skinny.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_smedia.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/alias_util.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/libalias/libalias.3#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/pim.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/pim_var.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/raw_ip.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_asconf.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_asconf.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_auth.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_auth.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_bsd_addr.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_bsd_addr.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_cc_functions.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_cc_functions.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_constants.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_crc32.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_crc32.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_header.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_indata.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_indata.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_input.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_input.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_lock_bsd.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_os.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_os_bsd.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_output.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_output.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_pcb.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_pcb.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_peeloff.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_peeloff.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_structs.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_sysctl.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_sysctl.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_timer.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_timer.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_uio.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_usrreq.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctp_var.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctputil.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/sctputil.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_debug.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_debug.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_fsm.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_hostcache.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_hostcache.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_input.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_lro.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_lro.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_offload.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_offload.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_output.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_reass.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_sack.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_seq.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_subr.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_syncache.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_syncache.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_timer.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_timer.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_timewait.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_usrreq.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcp_var.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/tcpip.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/toedev.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/udp.h#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/udp_usrreq.c#1 branch
.. //depot/projects/soc2009/marta_ipfw/src/sys/netinet/udp_var.h#1 branch

Differences ...



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200908031619.n73GJxOx064807>