Date: Sat, 9 Apr 2016 19:47:47 -0400 From: Jason Unovitch <junovitch@FreeBSD.org> To: TAKATSU Tomonari <tota@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r412848 - head/net-im/mikutter Message-ID: <20160409234747.GA28215@Silverstone.nc-us.unovitch.com> In-Reply-To: <201604091534.u39FYnm0009448@repo.freebsd.org> References: <201604091534.u39FYnm0009448@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On Sat, Apr 09, 2016 at 03:34:49PM +0000, TAKATSU Tomonari wrote: > Author: tota > Date: Sat Apr 9 15:34:49 2016 > New Revision: 412848 > URL: https://svnweb.freebsd.org/changeset/ports/412848 > > Log: > - Add missing RUN_DEPENDS > > PR: 208650 > Submitted by: Koichiro IWAO <meta+ports_AT_vmeta_DOT_jp> > > Modified: > head/net-im/mikutter/Makefile (contents, props changed) > > Modified: head/net-im/mikutter/Makefile > ============================================================================== > --- head/net-im/mikutter/Makefile Sat Apr 9 14:36:27 2016 (r412847) > +++ head/net-im/mikutter/Makefile Sat Apr 9 15:34:49 2016 (r412848) > @@ -3,6 +3,7 @@ > > PORTNAME= mikutter > PORTVERSION= 3.3.8 > +PORTREVISION= 1 > CATEGORIES= net-im ruby > MASTER_SITES= http://mikutter.hachune.net/bin/ \ > LOCAL/tota/${PORTNAME} > @@ -20,10 +21,13 @@ RUN_DEPENDS= rubygem-gtk2>=3.0.7:x11-too > rubygem-delayer>=0.0.2:devel/rubygem-delayer \ > rubygem-delayer-deferred>=1.0.3:devel/rubygem-delayer-deferred \ > rubygem-gettext>=3.0.9:devel/rubygem-gettext \ > + rubygem-httpclient>=2.7.1:www/rubygem-httpclient \ > rubygem-instance_storage>=1.0.0:devel/rubygem-instance_storage \ > rubygem-json_pure>=1.8.3:devel/rubygem-json_pure \ > rubygem-locale>=2.1.1:devel/rubygem-locale \ > rubygem-memoist>=0.14.0:devel/rubygem-memoist \ > + rubygem-moneta>=0.7:devel/rubygem-moneta \ > + rubygem-nokogiri>=1.6.7:textproc/rubygem-nokogiri \ > rubygem-oauth>=0.4.7:net/rubygem-oauth \ > rubygem-pluggaloid>=1.0.2:devel/rubygem-pluggaloid \ > rubygem-ruby-hmac>=0.4.0:security/rubygem-ruby-hmac \ > FYI, This is about as perfect example as any for MFH. The backtrace from the PR with missing rubygem-moneta make it a perfect canidate for MFH under the ports-secteam runtime fix blanket. % mikutter /usr/local/lib/ruby/2.3/amd64-freebsd10/continuation.so: warning: callcc is obsolete; use Fiber instead /usr/local/lib/ruby/site_ruby/2.3/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- moneta (LoadError) ... The commit could have been marked 'MFH: 2016Q2 (runtime fix blanket)' and immediately MFH'd. I've gone and done so, but keep it in mind for next time. As a reminder, the list of blanket approvals is here and listed below: https://wiki.FreeBSD.org/ports-secteam#Blanket_Approval Fixes that do not result in a change in contents of the resulting package. Examples: - - pkg-descr: WWW: URL updates (existing 404, moved or incorrect - - Build, Runtime or Packaging fixes, if the quarterly branch version is currently broken. - - Missing dependencies (detected, linked against but not registered via *_DEPENDS) - - Shebang, INSTALL_LIB, and plist fixes. - - Backport of security and reliability fixes which only result in PORTREVISION bumps and no changes to enabled features. For instance, addition of a patch for a buffer overflow. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJXCZScXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0NURGNTQ1OTkzQkJFMzc3OTNDQUNERUU2 RkQ0OUMzMDE2MUNBQTZFAAoJEG/UnDAWHKpuLH0H/2VaeNdX11KiQsGUwYbOlFx5 HH5BX7pfXw9s97HDebZzCPeORTMAsKCxFpExR5sybIUBj0phv56cvP+EDWPZHAH4 XAhreKt1DzApmM6zsgFqv5mYCTX4I3bSCsHt3oujmbX8eAWS36jkRv91dEYxpb3E B3OwstsFHIE0rAjxFo6g2sFfcA9kuH2b/f1i5nt+PwuIt4Em9h4mqwh49kSZYbKf 7KNMs7DU0CaNjO95MIrGCIdtMVNsWCjazKvK9RbuP6ePr1ac5/6spLJjiNizXcyk nKoJ5WZDGL9Yyq5J3fmDo9kZ4ZmZ2ZvHW54PIRXuiXCrrzReA5QtD6YSqEt6p20= =YD9a -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160409234747.GA28215>