Date: Tue, 4 Jan 2005 19:04:26 -0800 From: Brooks Davis <brooks@one-eyed-alien.net> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: scottl@freebsd.org Subject: Re: BigDisk project: du(1) 64bit clean. Message-ID: <20050105030426.GB24604@odin.ac.hmc.edu> In-Reply-To: <20050104224043.GM784@darkness.comp.waw.pl> References: <20050104224043.GM784@darkness.comp.waw.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
--aVD9QWMuhilNxW9f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 04, 2005 at 11:40:43PM +0100, Pawel Jakub Dawidek wrote: > Hi. >=20 > I want you to look at two patches which makes du(1) 64bit clean. > This work is part of the BigDisk project: >=20 > http://www.freebsd.org/projects/bigdisk/ >=20 > The main problem here is that du(1) uses fts(3) and fts_number field from > one of its structures to store size. > This field is defined as 'long' so it doesn't give us what we want > (on 32bit archs). >=20 > So first of all, we need this patch: >=20 > http://people.freebsd.org/~pjd/patches/fts.h.patch >=20 > It adds 64bit fts_bignum field, but because it is hiden under union, > it doesn't break ABI. It also doesn't break API, thanks to #defines. >=20 > Patch for du(1) is here: >=20 > http://people.freebsd.org/~pjd/patches/du-64bit-clean.patch >=20 > We should decide if we want fts.h.patch also in HEAD or only in RELENG_5, > because we can make it much cleaner in HEAD, but we will break ABI > (API should be quite ok) - we need to change size of fts_number field. I'd be inclined to use the somewhat gross fix in PR 74567 in RELENG_5 and do it right in HEAD. bde suggested changing fts_num to intmax_t. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --aVD9QWMuhilNxW9f Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFB21k6XY6L6fI4GtQRAjaZAJ9tniH3xspI4bx/8mJt6YABLOvXoACghYHi 1Rt4YC2eV0zvBt5S/PYCBdg= =vYru -----END PGP SIGNATURE----- --aVD9QWMuhilNxW9f--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050105030426.GB24604>