Date: Mon, 21 Feb 2005 12:59:15 +0100 (CET) From: Florent Thoumie <flz@xbsd.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: docs/77851: articles/committers-guide: change Approved -> Reviewed Message-ID: <20050221115915.8BB0C1161B@smtp.xbsd.org> Resent-Message-ID: <200502211200.j1LC0ct0043870@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 77851
>Category: docs
>Synopsis: articles/committers-guide: change Approved -> Reviewed
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-doc
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Feb 21 12:00:38 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Florent Thoumie
>Release: FreeBSD 5.3-RELEASE i386
>Organization:
Xbsd.org
>Environment:
System: FreeBSD srv1.xbsd.org 5.3-RELEASE FreeBSD 5.3-RELEASE #2: Wed Nov 24 16:35:34 CET 2004 root@gate.xbsd.org:/usr/src/sys/i386/compile/GATE i386
>Description:
These are two different statements of the Committer's Guide. I think the
second one is erroneous.
"Approved by" is only acceptable from non-mentored src committers -- mentored
committers can provide a "Reviewed by" but not an "Approved by".
Until your mentor decides (and announces with a forced commit to access) that
you have learned the ropes and are ready to commit on your own, you should not
commit anything without first getting your mentor's review and approval, and
you should document that approval with an Approved by: line in the commit
message.
>How-To-Repeat:
>Fix:
--- article.sgml.diff begins here ---
Index: article.sgml
===================================================================
RCS file: /home/ncvs/doc/en_US.ISO8859-1/articles/committers-guide/article.sgml,v
retrieving revision 1.219
diff -u -r1.219 article.sgml
--- article.sgml 22 Dec 2004 07:54:15 -0000 1.219
+++ article.sgml 21 Feb 2005 11:47:19 -0000
@@ -1148,7 +1148,7 @@
ropes and are ready to commit on your own, you should not commit
anything without first getting your mentor's review and
approval, and you should document that approval with an
- <literal>Approved by:</literal> line in the commit
+ <literal>Reviewed by:</literal> line in the commit
message.</para>
<para>All <filename>src</filename> commits should go to
--- article.sgml.diff ends here---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050221115915.8BB0C1161B>