Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Mar 2021 11:06:32 +0300
From:      Gleb Popov <arrowd@freebsd.org>
To:        "Danilo G. Baio" <dbaio@freebsd.org>
Cc:        ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>,  svn-ports-head <svn-ports-head@freebsd.org>
Subject:   Re: svn commit: r569233 - head/lang/ghc
Message-ID:  <CALH631m1HzFBdZfLs1EAe7WDRo5h_roE-_D3dVes28KufN7GAA@mail.gmail.com>
In-Reply-To: <202103260044.12Q0idbc009254@repo.freebsd.org>
References:  <202103260044.12Q0idbc009254@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 26, 2021 at 3:44 AM Danilo G. Baio <dbaio@freebsd.org> wrote:

> Author: dbaio
> Date: Fri Mar 26 00:44:39 2021
> New Revision: 569233
> URL: https://svnweb.freebsd.org/changeset/ports/569233
>
> Log:
>   lang/ghc: Generate PORTDOCS pkg-plist dynamically
>
>   This is the best approach for ports building its documentation with
> Sphinx in
>   html and will save time on future Sphinx updates.
>
>   Approved by:  portmgr blanket
>
> Modified:
>   head/lang/ghc/Makefile
>   head/lang/ghc/pkg-plist
>
> Modified: head/lang/ghc/Makefile
>
> ==============================================================================
> --- head/lang/ghc/Makefile      Fri Mar 26 00:40:44 2021        (r569232)
> +++ head/lang/ghc/Makefile      Fri Mar 26 00:44:39 2021        (r569233)
> @@ -84,6 +84,8 @@ BOOT_LLVM_VERSION=    90
>
>  PLIST_SUB=             GHC_VERSION=${GHC_VERSION}
> CABAL_VERSION=${CABAL_VERSION}
>
> +PORTDOCS=              *
> +
>  .include <bsd.port.pre.mk>
>
>  # This version of ncurses is needed by bootstrap compiler
>

I spent quite a time to make the pkg-plist fully static, and now you make
such a change without consulting the port's maintainer.

I was thinking that static pkg-plist's are generally favored over
dynamically-generated ones. Why usual "make makeplist" didn't work for you?
Why didn't you ask me to help you with Sphinx upgrade?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631m1HzFBdZfLs1EAe7WDRo5h_roE-_D3dVes28KufN7GAA>