Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Mar 2013 19:23:03 GMT
From:      Norihiko Murase <mur1080224@inter7.jp>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/177353: [PATCH] ftp/yafc: fix for NLS support
Message-ID:  <201303241923.r2OJN3x6021212@red.freebsd.org>
Resent-Message-ID: <201303241930.r2OJU0r3019866@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         177353
>Category:       ports
>Synopsis:       [PATCH] ftp/yafc: fix for NLS support
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 24 19:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Norihiko Murase
>Release:        
>Organization:
>Environment:
>Description:
- Fix the wrong configure option for NLS support that should be specified
  in building:
    (NG) --(enable|disable)-nls
    (OK) --(with|without)-gettext
- Delete unnecessary library link for NLS support
  ("-lintl" is added by the configure script executed even if it is
  not specified here.)

>How-To-Repeat:

>Fix:
Patch attached with submission should be imported.


Patch attached with submission follows:

diff -urN ports.old/Makefile ports.new/Makefile
--- ports.old/Makefile	2013-01-20 08:12:43.000000000 +0900
+++ ports.new/Makefile	2013-03-25 03:53:24.000000000 +0900
@@ -34,33 +34,35 @@
 .include <bsd.port.options.mk>
 
 .if ${PORT_OPTIONS:MNLS}
+CONFIGURE_ARGS+=	--with-gettext
 USE_GNOME+=	intltool
 USE_GETTEXT=	yes
-LDFLAGS+=	-lintl
 PLIST_FILES+=	share/locale/de/LC_MESSAGES/yafc.mo \
 		share/locale/sv/LC_MESSAGES/yafc.mo
 .else
-CONFIGURE_ARGS+=	--disable-nls
+CONFIGURE_ARGS+=	--without-gettext
 .endif
 
 .if ${PORT_OPTIONS:MREADLINE}
+CONFIGURE_ARGS+=	--with-readline
 USE_READLINE=	yes
 .else
 CONFIGURE_ARGS+=	--without-readline
 .endif
 
 .if ${PORT_OPTIONS:MSSH}
+CONFIGURE_ARGS+=	--with-ssh
 LIB_DEPENDS+=	ssh:${PORTSDIR}/security/libssh
 .else
 CONFIGURE_ARGS+=	--without-ssh
 .endif
 
 .if ${PORT_OPTIONS:MBASH}
-CONFIGURE_ARGS+=	--with-bash-completion=yes
+CONFIGURE_ARGS+=	--with-bash-completion
 PLIST_FILES+=		etc/bash_completion.d/yafc
 PLIST_DIRSTRY=		etc/bash_completion.d
 .else
-CONFIGURE_ARGS+=	--with-bash-completion=no
+CONFIGURE_ARGS+=	--without-bash-completion
 .endif
 
 post-install:


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303241923.r2OJN3x6021212>