Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Jul 2013 21:30:53 +0000 (UTC)
From:      Jim Harris <jimharris@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r253473 - head/sys/dev/nvd
Message-ID:  <201307192130.r6JLUrSI059706@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jimharris
Date: Fri Jul 19 21:30:53 2013
New Revision: 253473
URL: http://svnweb.freebsd.org/changeset/base/253473

Log:
  Do not call disk_create() until we have completed all initialization of our
  internal disk structure.
  
  Sponsored by:	Intel
  Reviewed by:	carl
  MFC after:	3 days

Modified:
  head/sys/dev/nvd/nvd.c

Modified: head/sys/dev/nvd/nvd.c
==============================================================================
--- head/sys/dev/nvd/nvd.c	Fri Jul 19 21:16:59 2013	(r253472)
+++ head/sys/dev/nvd/nvd.c	Fri Jul 19 21:30:53 2013	(r253473)
@@ -318,8 +318,6 @@ nvd_new_disk(struct nvme_namespace *ns, 
 	    min(sizeof(disk->d_descr), NVME_MODEL_NUMBER_LENGTH));
 #endif
 
-	disk_create(disk, DISK_VERSION);
-
 	ndisk->ns = ns;
 	ndisk->disk = disk;
 	ndisk->cur_depth = 0;
@@ -335,6 +333,8 @@ nvd_new_disk(struct nvme_namespace *ns, 
 	TAILQ_INSERT_TAIL(&disk_head, ndisk, global_tailq);
 	TAILQ_INSERT_TAIL(&ctrlr->disk_head, ndisk, ctrlr_tailq);
 
+	disk_create(disk, DISK_VERSION);
+
 	return (NULL);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307192130.r6JLUrSI059706>