Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Oct 2003 21:15:02 +0200
From:      "Poul-Henning Kamp" <phk@phk.freebsd.dk>
To:        Nate Lawson <nate@root.org>
Cc:        cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern vfs_bio.c src/sys/fs/nwfs nwfs_vnops.c src/sys/fs/smbfs smbfs_vnops.c 
Message-ID:  <9205.1066504502@critter.freebsd.dk>
In-Reply-To: Your message of "Sat, 18 Oct 2003 12:13:09 PDT." <20031018121152.V47115@root.org> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20031018121152.V47115@root.org>, Nate Lawson writes:

>> @@ -799,8 +799,7 @@
>>  	KASSERT(ap->a_vp == ap->a_bp->b_vp, ("%s(%p != %p)",
>>  	    __func__, ap->a_vp, ap->a_bp->b_vp));
>>  	NCPVNDEBUG("\n");
>> -	if (bp->b_flags & B_PHYS)
>> -		panic("nwfs physio");
>> +	KASSERT(!(bp->b_flags & B_PHYS), ("nwfs physio"));
>>  	if (bp->b_flags & B_ASYNC)
>>  		td = (struct thread *)0;
>  	else
>
>This removes sanity checks for the !INVARIANTS case (which all our
>releases are).

This sanity-check is OBE, and B_PHYS as such is about to disappear.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9205.1066504502>