Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Nov 2017 09:30:27 -0500
From:      Ryan Steinmetz <zi@freebsd.org>
To:        "John W. O'Brien" <john@saltant.com>
Cc:        FreeBSD Ports <freebsd-ports@freebsd.org>, Kubilay Kocak <koobs@FreeBSD.org>
Subject:   Re: net/freeradius3 maintainer is ignoring the port (timeout)
Message-ID:  <20171109143027.GA15287@exodus.zi0r.com>
In-Reply-To: <c0b18c88-7c0f-76e9-2785-d03a5a56234a@saltant.com>
References:  <14e8585a-e7bc-4ee3-2f28-8620c9ef5488@saltant.com> <20171108001601.GB81707@exodus.zi0r.com> <c0b18c88-7c0f-76e9-2785-d03a5a56234a@saltant.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On (11/08/17 20:31), John W. O'Brien wrote:
>On 2017/11/07 19:16, Ryan Steinmetz wrote:
>> On (11/06/17 22:11), John W. O'Brien wrote:
>>> Hello FreeBSD ports,
>>>
>>> The maintainer of net/freeradius3 is unresponsive on two open bugs, b=
oth
>>> with proposed patches.
>>
>> John,
>>
>> I was reviewing these two issues tonight and, if I am not mistaken, th=
e
>> IDN issue was resolved in a commit on 7/17/17:
>> https://svnweb.freebsd.org/ports/head/net/freeradius3/pkg-plist?r1=3D4=
42287&r2=3D446076
>
>Hi Ryan,
>
>The change you cite allows the port to build with the IDN option.
>However, it appears that this fragment of the Makefile needs some TLC.
>Is the IDN module experimental or not?
>


To me, this feels a little nit-picky and isn't something that an=20
end-user is actually going to see.


># freetds module is still experimental
>.if ${PORT_OPTIONS:MIDN} && empty(PORT_OPTIONS:MEXPERIMENTAL)
>EXPM=3D           yes
>.endif
>
>> I also believe that the Kerberos issue was resolved on 4/1/16:
>> https://svnweb.freebsd.org/ports/head/net/freeradius3/Makefile?r1=3D41=
2347&r2=3D412348&
>>
>> Can you please verify your ports tree is current (you should see
>> FreeRADIUS 3.0.15) and then confirm/deny?
>
>$ svn info /usr/ports | grep Revision
>Revision: 453233
>$ svn log -v -r 453233:HEAD /usr/ports/net/freeradius3
>------------------------------------------------------------------------
>
>The issue persists. Here are some relevant excerpts from a poudriere
>testport build.
>

OK so MIT Kerberos integration isn't 100%, but the Heimdal stuff works.

I'll check this out.

-r

>[...]
>---Begin OPTIONS List---
>=3D=3D=3D> The following configuration options are available for
>freeradius3-3.0.15_1:
>     DEVELOPER=3Doff: Enable developer options
>     DOCS=3Doff: Build and/or install documentation
>     EDIR=3Doff: Enable eDirectory support (implies LDAP)
>     EXPERIMENTAL=3Doff: Build experimental modules
>     FIREBIRD=3Doff: With Firebird database support (EXPERIMENTAL)
>     FREETDS=3Doff: FreeTDS library support
>     HEIMDAL=3Doff: With Heimdal Kerberos support
>     HEIMDAL_PORT=3Doff: With Heimdal Kerberos from ports
>     IDN=3Doff: International Domain Names support
>     KERBEROS=3Don: Kerberos support
>     LDAP=3Doff: LDAP protocol support
>     MYSQL=3Doff: MySQL database support
>     PERL=3Don: Perl scripting language support
>     PGSQL=3Doff: PostgreSQL database support
>     PYTHON=3Doff: Python bindings or support
>     REDIS=3Doff: Redis key-value store database support
>     REST=3Doff: Enable RESTful API support
>     RUBY=3Doff: Ruby bindings or support
>     SQLITE3=3Doff: SQLite 3 database support
>     UDPFROMTO=3Doff: Compile in UDPFROMTO support
>     UNIXODBC=3Doff: With unixODBC database support
>     USER=3Don: Run as user freeradius, group freeradius
>=3D=3D=3D> Use 'make config' to modify these settings
>---End OPTIONS List---
>
>--CONFIGURE_ARGS--
>--without-rlm_sql_sqlite --with-rlm_krb5
>--with-rlm-krb5-lib-dir=3D/usr/local/lib --wi
>th-rlm-krb5-include-dir=3D/usr/local/include --without-edir
>--without-rlm_ldap --without-rlm_sql_mysql --without-rlm_sql_postgresql
>--without-rlm_sql_unixodbc --without-rlm_sql_firebird --with-rlm_perl
>--without-rlm_python --without-rlm_ruby --with-ruby=3Dno
>--without-rlm_redis --without-rlm_rediswho --without-rlm_rest
>--without-rlm_freetds --without-rlm_idn --without-experimental-modules
>--quiet --without-docdir --with-openssl-libraries=3D/usr/local/lib
>--with-logdir=3D/var/log  --with-openssl-includes=3D/usr/local/include
>--prefix=3D/usr/local --libdir=3D/usr/local/lib/freeradius-3.0.15
>--localstatedir=3D/var  --without-rlm_eap_ikev2  --without-rlm_eap_tnc
>--without-rlm_eap2  --without-rlm_opendirectory  --without-rlm_sql_db2
>--without-rlm_sql_iodbc  --without-rlm_sql_sybase  --without-rlm_yubikey
> --without-rlm_sql_oracle  --without-rlm_securid
>--without-rlm_cache_memcached  --with-vmps
>--with-collectdclient-lib-dir=3D/dev/null  --disable-openssl-version-che=
ck
>--with-pic --prefix=3D/usr/local ${_LATE_CONFIGURE_ARGS}
>--End CONFIGURE_ARGS--
>
>--CONFIGURE_ENV--
>MAKE=3Dgmake ac_cv_path_PERL=3D/usr/local/bin/perl
>ac_cv_path_PERL_PATH=3D/usr/local/bin/perl  PERL_USE_UNSAFE_INC=3D1
>XDG_DATA_HOME=3D/wrkdirs/usr/ports/net/freeradius3/work
>XDG_CONFIG_HOME=3D/wrkdirs/usr/ports/net/freeradius3/work
>HOME=3D/wrkdirs/usr/ports/net/freeradius3/work TMPDIR=3D"/tmp"
>PATH=3D/wrkdirs/usr/ports/net/freeradius3/work/.bin:/sbin:/bin:/usr/sbin=
:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin
>SHELL=3D/bin/sh CONFIG_SHELL=3D/bin/sh
>CONFIG_SITE=3D/usr/ports/Templates/config.site lt_cv_sys_max_cmd_len=3D2=
62144
>--End CONFIGURE_ENV--
>
>--MAKE_ENV--
>OPENSSLBASE=3D/usr/local OPENSSLDIR=3D/usr/local/openssl
>OPENSSLINC=3D/usr/local/include OPENSSLLIB=3D/usr/local/lib
>OPENSSLRPATH=3D/usr/local/lib PERL_USE_UNSAFE_INC=3D1
>XDG_DATA_HOME=3D/wrkdirs/usr/ports/net/freeradius3/work
>XDG_CONFIG_HOME=3D/wrkdirs/usr/ports/net/freeradius3/work
>HOME=3D/wrkdirs/usr/ports/net/freeradius3/work TMPDIR=3D"/tmp"
>PATH=3D/wrkdirs/usr/ports/net/freeradius3/work/.bin:/sbin:/bin:/usr/sbin=
:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin
>NO_PIE=3Dyes WITHOUT_DEBUG_FILES=3Dyes WITHOUT_KERNEL_SYMBOLS=3Dyes
>SHELL=3D/bin/sh NO_LINT=3DYES PREFIX=3D/usr/local  LOCALBASE=3D/usr/loca=
l
>LIBDIR=3D"/usr/lib"  CC=3D"cc" CFLAGS=3D"-O2 -pipe  -I/usr/local/include
>-fstack-protector -fno-strict-aliasing"  CPP=3D"cpp"
>CPPFLAGS=3D"-I/usr/local/include"  LDFLAGS=3D" -L/usr/local/lib
>-Wl,-rpath,/usr/local/lib -fstack-protector" LIBS=3D""  CXX=3D"c++"
>CXXFLAGS=3D"-O2 -pipe -I/usr/local/include -fstack-protector
>-fno-strict-aliasing "  MANPREFIX=3D"/usr/local"
>BSD_INSTALL_PROGRAM=3D"install  -s -m 555"  BSD_INSTALL_LIB=3D"install  =
-s
>-m 0644"  BSD_INSTALL_SCRIPT=3D"install  -m 555"
>BSD_INSTALL_DATA=3D"install  -m 0644"  BSD_INSTALL_MAN=3D"install  -m 44=
4"
>--End MAKE_ENV--
>[...]
>CC src/modules/proto_dhcp/rlm_dhcp.c
>In file included from src/modules/rlm_krb5/krb5.c:28:
>src/modules/rlm_krb5/krb5.h:41:2: error: unknown type name 'krb5_verify_=
opt'
>        krb5_verify_opt options;
>        ^
>src/modules/rlm_krb5/krb5.c:151:2: warning: implicit declaration of
>function 'krb5_verify_opt_init' is invalid in C99
>[-Wimplicit-function-declaration]
>        krb5_verify_opt_init(&conn->options);
>        ^
>src/modules/rlm_krb5/krb5.c:152:2: warning: implicit declaration of
>function 'krb5_verify_opt_set_ccache' is invalid in C99
>[-Wimplicit-function-declaration]
>        krb5_verify_opt_set_ccache(&conn->options, conn->ccache);
>        ^
>src/modules/rlm_krb5/krb5.c:154:2: warning: implicit declaration of
>function 'krb5_verify_opt_set_keytab' is invalid in C99
>[-Wimplicit-function-declaration]
>        krb5_verify_opt_set_keytab(&conn->options, conn->keytab);
>        ^
>src/modules/rlm_krb5/krb5.c:155:2: warning: implicit declaration of
>function 'krb5_verify_opt_set_secure' is invalid in C99
>[-Wimplicit-function-declaration]
>        krb5_verify_opt_set_secure(&conn->options, true);
>        ^
>src/modules/rlm_krb5/krb5.c:157:21: warning: implicit declaration of
>function 'krb5_verify_opt_set_service' is invalid in C99
>[-Wimplicit-function-declaration]
>        if (inst->service) krb5_verify_opt_set_service(&conn->options,
>inst->service);
>                           ^
>5 warnings and 1 error generated.
>gmake[1]: *** [scripts/boiler.mk:636:
>build/objs/src/modules/rlm_krb5/krb5.lo] Error 1
>gmake[1]: *** Waiting for unfinished jobs....
>In file included from src/modules/rlm_krb5/rlm_krb5.c:32:
>src/modules/rlm_krb5/krb5.h:41:2: error: unknown type name 'krb5_verify_=
opt'
>        krb5_verify_opt options;
>        ^
>src/modules/rlm_krb5/rlm_krb5.c:347:8: warning: implicit declaration of
>function 'krb5_verify_user_opt' is invalid in C99
>[-Wimplicit-function-declaration]
>        ret =3D krb5_verify_user_opt(conn->context, client,
>request->password->vp_strvalue, &conn->options);
>              ^
>1 warning and 1 error generated.
>gmake[1]: *** [scripts/boiler.mk:637:
>build/objs/src/modules/rlm_krb5/rlm_krb5.lo] Error 1
>gmake[1]: Leaving directory
>'/wrkdirs/usr/ports/net/freeradius3/work/freeradius-server-3.0.15'
>=3D=3D=3D> Compilation failed unexpectedly.
>
>
>>> In one case [0], the submitter responded to feedback on 2016-02-03,
>>> there has been no further action on the part of the maintainer, and t=
he
>>> port remains broken w.r.t. Kerberos.
>>>
>>> In the other case [1], there was already one maintainer timeout (5 mo=
 as
>>> of 2016-07-17). The bug was reassigned to the maintainer on 2017-08-1=
8,
>>> and there has been no further action.
>>>
>>> I would appreciate it if somebody could give these bugs the attention
>>> they need.
>>>
>>> Also, I ask that if the maintainer is unable or unwilling to attend t=
o
>>> reported problems, that the port be released so that others could mor=
e
>>> easily work to improve it.
>>>
>>> Regards,
>>> John
>>>
>>> [0] net/freeradius3: Fix pkg-plist with IDN option
>>> =A0=A0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202684
>>> [1] net/freeradius3: Does not link properly against selected kerberos
>>> implementation
>>> =A0=A0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205493
>>>
>>
>>
>>
>>
>
>




--=20
Ryan Steinmetz
PGP: 9079 51A3 34EF 0CD4 F228  EDC6 1EF8 BA6B D028 46D7



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171109143027.GA15287>