Date: Wed, 28 May 2003 14:27:42 -0700 (PDT) From: Nate Lawson <nate@root.org> To: Mark Linimon <linimon@lonesome.com> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/dev/acpica - Imported sources Message-ID: <20030528142349.I8609@root.org> In-Reply-To: <200305281558.51481.linimon@lonesome.com> References: <200305271919.h4RJJ5kd039145@repoman.freebsd.org> <xzpznl7c7zh.fsf@flood.ping.uio.no> <20030528102708.J8183@root.org> <200305281558.51481.linimon@lonesome.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 28 May 2003, Mark Linimon wrote: > > I'll do more compile testing in the future but it is painful since my > > system takes so long to build. > > Nate, you may feel I'm picking on you specifically, but I'm not. > I'm saying that it doesn't make sense to use the tinderboxen > to be doing compile testing after a freeze has supposedly gone > into effect. After a freeze goes into effect, IMVVHO the only > things that should go into the tree are things that multiple people > have already beat the (*&^(*&^ out of and thus have almost no risk > and almost certain gain. Um, the build breakage was a static function which became unstaticized without a prototype. The "fix" is to add static back to the function. The functionality behind the patch (the rest of it) HAD been run-time tested and fixed known problems for us and had been in the NetBSD tree for a few weeks. It so happens that spare time to work on FreeBSD seems to work in relation to the inverse of release cycles. :) So mea culpa, etc., will try harder next time. -Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030528142349.I8609>