Date: Tue, 15 Jan 2019 09:33:18 +0000 From: bugzilla-noreply@freebsd.org To: pf@FreeBSD.org Subject: [Bug 230619] pf: tables use non SMP-friendly counters Message-ID: <bug-230619-16861-aojswntWz4@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-230619-16861@https.bugs.freebsd.org/bugzilla/> References: <bug-230619-16861@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230619 --- Comment #5 from Kristof Provost <kp@freebsd.org> --- Apologies for taking this long to get back to this. I've had other prioriti= es in the past few months. I'm not sure about the M_WAITOK in pfr_create_kentry(), because the initial allocation there (for the pfr_kentry) is M_NOWAIT. It'll have to be another M_NOWAIT allocation, with appropriate error handling. The same applies to pfr_create_ktable(). In 'case PFRW_GET_ASTATS' it might make sense to move that code into its own function, if only to avoid the line length issues. It's so broken up now th= at it's not very readable any more. Other than those minor points, I think this is ready to go in. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-230619-16861-aojswntWz4>