Date: Thu, 29 Aug 2019 06:21:48 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Kirill Ponomarev <krion@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r510145 - head/sysutils/screen Message-ID: <6624DB64-13E5-494D-AC1D-16D002AD5D2E@cschubert.com> In-Reply-To: <20190829130900.7qqm5rv3z3zgnmdw@ivaldir.net> References: <201908290638.x7T6cVFc033808@repo.freebsd.org> <201908291230.x7TCUgKI027625@slippy.cwsent.com> <20190829124225.r7gpumnvtbeguuoz@ivaldir.net> <201908291254.x7TCsFCI051889@slippy.cwsent.com> <20190829130900.7qqm5rv3z3zgnmdw@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On August 29, 2019 6:09:00 AM PDT, Baptiste Daroussin <bapt@FreeBSD=2Eorg> = wrote: >On Thu, Aug 29, 2019 at 05:54:15AM -0700, Cy Schubert wrote: >> In message <20190829124225=2Er7gpumnvtbeguuoz@ivaldir=2Enet>, Baptiste= =20 >> Daroussin wr >> ites: >> >=20 >> > >> > --vmfceac25l47d6el >> > Content-Type: text/plain; charset=3Dus-ascii >> > Content-Disposition: inline >> > Content-Transfer-Encoding: quoted-printable >> > >> > On Thu, Aug 29, 2019 at 05:30:42AM -0700, Cy Schubert wrote: >> > > In message <201908290638=2Ex7T6cVFc033808@repo=2Efreebsd=2Eorg>, Ki= rill >Ponomar=3D >> > ev=3D20 >> > > wri >> > > tes: >> > > > Author: krion >> > > > Date: Thu Aug 29 06:38:31 2019 >> > > > New Revision: 510145 >> > > > URL: https://svnweb=2Efreebsd=2Eorg/changeset/ports/510145 >> > > > >> > > > Log: >> > > > Remove building man page by default=2E It's currently broken on >HEAD >> > > > and requires to build textproc/groff which requires >devel/llvm80 >> > > > which is an overkill for using screen=2E >> > > > >> > > > Modified: >> > > > head/sysutils/screen/Makefile >> > > > >> > > > Modified: head/sysutils/screen/Makefile >> > > > >=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D= 3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D >> > >=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D= 3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D >> > >=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D= 3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D >> > =3D3D=3D3D=3D3D=3D3D >> > > > =3D3D >> > > > --- head/sysutils/screen/Makefile Thu Aug 29 06:37:17 >2019 (r51014 >> > > > 4) >> > > > +++ head/sysutils/screen/Makefile Thu Aug 29 06:38:31 >2019 (r51014 >> > > > 5) >> > > > @@ -3,7 +3,7 @@ >> > > > =3D20 >> > > > PORTNAME=3D3D screen >> > > > PORTVERSION=3D3D 4=2E6=2E2 >> > > > -PORTREVISION=3D3D 1 >> > > > +PORTREVISION=3D3D 2 >> > > > CATEGORIES=3D3D sysutils >> > > > MASTER_SITES=3D3D GNU \ >> > > > ftp://ftp=2Egnu=2Eorg/gnu/screen/ \ >> > > > @@ -20,7 +20,7 @@ COMMENT=3D3D Multi-screen window manager >> > > > LICENSE=3D3D GPLv3 >> > > > =3D20 >> > > > OPTIONS_DEFINE=3D3D INFO MAN NETHACK XTERM_256 SHOWENC SYST >> > EM_SCREE >> > > > NRC >> > > > -OPTIONS_DEFAULT=3D3D INFO MAN NETHACK XTERM_256 SOCKETS >SYSTEM_SCREE >> > NRC \ >> > > > +OPTIONS_DEFAULT=3D3D INFO NETHACK XTERM_256 SOCKETS >SYSTEM_SCREENRC=20 >> > \ >> > > > NCURSES_DEFAULT >> > > > OPTIONS_SINGLE=3D3D IPC NCURSES >> > > > OPTIONS_SINGLE_IPC=3D3D SOCKETS NAMED_PIPES >> > > > >> > >=3D20 >> > > Should you not have obtained maintainer approval for this first? >> > >=3D20 >> > > And now the package will not include man pages=2E Can I assign >those PRs to=3D >> > =3D20 >> > > you? >> > >=3D20 >> > >> > I do think the best approach to this is to drop the MAN page >option, it mak=3D >> > es >> > little sense not to install it=2E and not add groff as a runtime >dependency >> > anyway=2E >>=20 >> I've had this same issue with krb5=2E Pkg end users expect man pages=2E >>=20 >> > >> > The reason why man(1) is telling the users to install groff(1) is >exactly f=3D >> > or >> > that, the users do decide if he wants to read that manpage on his >system an=3D >> > d do >> > install groff, or he reads it online and do not install it at all=2E >the other >> > point is in the future screen(1) might become mandoc compatible=2E >and you wi=3D >> > ll >> > still grab in the groff(1) dependency=2E >>=20 >> I'm willing to live with this but it is still disrespectful not to >involve=20 >> the maintainer=2E >>=20 >> Can I point to this email thread as a precedent if or when I commit >to a=20 >> port maintained by someone else? > >For sure the maintainer should have been involved! and also my proposal >if >different from what has been done here=2E ;) > >Best regards, >Bapt If and when I have the inclination to look at this, I will=2E In the mean = time patches are welcome=2E --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert <Cy=2ESchubert@cschubert=2Ecom> FreeBSD UNIX: <cy@FreeBSD=2Eorg> Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6624DB64-13E5-494D-AC1D-16D002AD5D2E>