Date: Mon, 8 Jul 2002 08:36:20 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Don Lewis <dl-freebsd@catspoiler.org> Cc: brooks@one-eyed-alien.net, <iedowse@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sbin/dump tape.c traverse.c Message-ID: <20020708082008.J13478-100000@gamplex.bde.org> In-Reply-To: <200207072143.g67Lh10M023883@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 7 Jul 2002, Don Lewis wrote: > On 7 Jul, Brooks Davis wrote: > > On Sun, Jul 07, 2002 at 05:30:21AM -0700, Ian Dowse wrote: > >> iedowse 2002/07/07 05:30:21 PDT > >> > >> Modified files: > >> sbin/dump tape.c traverse.c > >> Log: > >> Fix some printf format errors. > > > > Do we really want to fix printf errors wwith %qd? A cast to intmax_t > > and %jd is at least C99 compliant where as %qd is a FreeBSDism. > > There were already a bunch of %qd formats in the code, so the patch I > suggested changed a bunch of %d formats associated with int64_t values > to match. I certainly wouldn't object if someone wanted to convert all > the %qd formats to %jd. %qd is just a different printf format error. E.g., on alphas, it happens to work, but it doesn't compile cleanly (since %qd is equivalent to %lld which is for printing long longs, but int64_t is plain long). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020708082008.J13478-100000>