Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Apr 2015 11:25:44 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Justin Hibbits <jhibbits@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r281721 - head/sys/sys
Message-ID:  <476583045.Qcb6O2DFtY@ralph.baldwin.cx>
In-Reply-To: <201504190033.t3J0XMDX041769@svn.freebsd.org>
References:  <201504190033.t3J0XMDX041769@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, April 19, 2015 12:33:22 AM Justin Hibbits wrote:
> Author: jhibbits
> Date: Sun Apr 19 00:33:21 2015
> New Revision: 281721
> URL: https://svnweb.freebsd.org/changeset/base/281721
> 
> Log:
>   Fix the build.  Commit the last part of e500 PMC.
>   
>   Pointy hat to:	jhibbits
> 
> Modified:
>   head/sys/sys/pmc.h
> 
> Modified: head/sys/sys/pmc.h
> ==============================================================================
> --- head/sys/sys/pmc.h	Sun Apr 19 00:29:02 2015	(r281720)
> +++ head/sys/sys/pmc.h	Sun Apr 19 00:33:21 2015	(r281721)
> @@ -102,6 +102,8 @@
>  	__PMC_CPU(MIPS_OCTEON,  0x201,  "Cavium Octeon")	\
>  	__PMC_CPU(MIPS_74K,     0x202,  "MIPS 74K")		\
>  	__PMC_CPU(PPC_7450,     0x300,  "PowerPC MPC7450")	\
> +	__PMC_CPU(PPC_E500,     0x340,  "PowerPC e500 Core")	\
> +	__PMC_CPU(PPC_MPC85XX,  0x340,  "Freescale PowerPC MPC85XX")	\
>  	__PMC_CPU(PPC_970,      0x380,  "IBM PowerPC 970")	\
>  	__PMC_CPU(GENERIC, 	0x400,  "Generic")
>  
> @@ -136,6 +138,7 @@ enum pmc_cputype {
>  	__PMC_CLASS(MIPS74K)	/* MIPS 74K */				\
>  	__PMC_CLASS(PPC7450)	/* Motorola MPC7450 class */		\
>  	__PMC_CLASS(PPC970)	/* IBM PowerPC 970 class */		\
> +	__PMC_CLASS(E500)	/* Freescale e500 class */		\
>  	__PMC_CLASS(SOFT)	/* Software events */

Note that each time a PMC_CLASS is added, the ABI for pmccontrol -L
breaks since the enum value of the "SOFT" class changes.  We should
perhaps fix the value of SOFT to make this less painful (just as we
fix the values for PMC_CPU so that those don't change).

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?476583045.Qcb6O2DFtY>