Date: Thu, 29 Aug 2019 15:37:13 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Kirill Ponomarev <krion@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r510145 - head/sysutils/screen Message-ID: <20190829133713.5l3jk67el47gdmfb@ivaldir.net> In-Reply-To: <6624DB64-13E5-494D-AC1D-16D002AD5D2E@cschubert.com> References: <201908290638.x7T6cVFc033808@repo.freebsd.org> <201908291230.x7TCUgKI027625@slippy.cwsent.com> <20190829124225.r7gpumnvtbeguuoz@ivaldir.net> <201908291254.x7TCsFCI051889@slippy.cwsent.com> <20190829130900.7qqm5rv3z3zgnmdw@ivaldir.net> <6624DB64-13E5-494D-AC1D-16D002AD5D2E@cschubert.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--kv3xxe43po3ksi5m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 29, 2019 at 06:21:48AM -0700, Cy Schubert wrote: > On August 29, 2019 6:09:00 AM PDT, Baptiste Daroussin <bapt@FreeBSD.org> = wrote: > >On Thu, Aug 29, 2019 at 05:54:15AM -0700, Cy Schubert wrote: > >> In message <20190829124225.r7gpumnvtbeguuoz@ivaldir.net>, Baptiste=20 > >> Daroussin wr > >> ites: > >> >=20 > >> > > >> > --vmfceac25l47d6el > >> > Content-Type: text/plain; charset=3Dus-ascii > >> > Content-Disposition: inline > >> > Content-Transfer-Encoding: quoted-printable > >> > > >> > On Thu, Aug 29, 2019 at 05:30:42AM -0700, Cy Schubert wrote: > >> > > In message <201908290638.x7T6cVFc033808@repo.freebsd.org>, Kirill > >Ponomar=3D > >> > ev=3D20 > >> > > wri > >> > > tes: > >> > > > Author: krion > >> > > > Date: Thu Aug 29 06:38:31 2019 > >> > > > New Revision: 510145 > >> > > > URL: https://svnweb.freebsd.org/changeset/ports/510145 > >> > > > > >> > > > Log: > >> > > > Remove building man page by default. It's currently broken on > >HEAD > >> > > > and requires to build textproc/groff which requires > >devel/llvm80 > >> > > > which is an overkill for using screen. > >> > > > > >> > > > Modified: > >> > > > head/sysutils/screen/Makefile > >> > > > > >> > > > Modified: head/sysutils/screen/Makefile > >> > > > > >=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > >> > > >=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > >> > > >=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > >> > =3D3D=3D3D=3D3D=3D3D > >> > > > =3D3D > >> > > > --- head/sysutils/screen/Makefile Thu Aug 29 06:37:17 > >2019 (r51014 > >> > > > 4) > >> > > > +++ head/sysutils/screen/Makefile Thu Aug 29 06:38:31 > >2019 (r51014 > >> > > > 5) > >> > > > @@ -3,7 +3,7 @@ > >> > > > =3D20 > >> > > > PORTNAME=3D3D screen > >> > > > PORTVERSION=3D3D 4.6.2 > >> > > > -PORTREVISION=3D3D 1 > >> > > > +PORTREVISION=3D3D 2 > >> > > > CATEGORIES=3D3D sysutils > >> > > > MASTER_SITES=3D3D GNU \ > >> > > > ftp://ftp.gnu.org/gnu/screen/ \ > >> > > > @@ -20,7 +20,7 @@ COMMENT=3D3D Multi-screen window manager > >> > > > LICENSE=3D3D GPLv3 > >> > > > =3D20 > >> > > > OPTIONS_DEFINE=3D3D INFO MAN NETHACK XTERM_256 SHOWENC SYST > >> > EM_SCREE > >> > > > NRC > >> > > > -OPTIONS_DEFAULT=3D3D INFO MAN NETHACK XTERM_256 SOCKETS > >SYSTEM_SCREE > >> > NRC \ > >> > > > +OPTIONS_DEFAULT=3D3D INFO NETHACK XTERM_256 SOCKETS > >SYSTEM_SCREENRC=20 > >> > \ > >> > > > NCURSES_DEFAULT > >> > > > OPTIONS_SINGLE=3D3D IPC NCURSES > >> > > > OPTIONS_SINGLE_IPC=3D3D SOCKETS NAMED_PIPES > >> > > > > >> > >=3D20 > >> > > Should you not have obtained maintainer approval for this first? > >> > >=3D20 > >> > > And now the package will not include man pages. Can I assign > >those PRs to=3D > >> > =3D20 > >> > > you? > >> > >=3D20 > >> > > >> > I do think the best approach to this is to drop the MAN page > >option, it mak=3D > >> > es > >> > little sense not to install it. and not add groff as a runtime > >dependency > >> > anyway. > >>=20 > >> I've had this same issue with krb5. Pkg end users expect man pages. > >>=20 > >> > > >> > The reason why man(1) is telling the users to install groff(1) is > >exactly f=3D > >> > or > >> > that, the users do decide if he wants to read that manpage on his > >system an=3D > >> > d do > >> > install groff, or he reads it online and do not install it at all. > >the other > >> > point is in the future screen(1) might become mandoc compatible. > >and you wi=3D > >> > ll > >> > still grab in the groff(1) dependency. > >>=20 > >> I'm willing to live with this but it is still disrespectful not to > >involve=20 > >> the maintainer. > >>=20 > >> Can I point to this email thread as a precedent if or when I commit > >to a=20 > >> port maintained by someone else? > > > >For sure the maintainer should have been involved! and also my proposal > >if > >different from what has been done here. ;) > > > >Best regards, > >Bapt >=20 > If and when I have the inclination to look at this, I will. In the mean t= ime patches are welcome. >=20 https://reviews.freebsd.org/D21463 This is what I do propose Best regards, Bapt --kv3xxe43po3ksi5m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl1n1QYACgkQY4mL3PG3 PlqNcA/+MY3eoEnCowzYvTgL4IoaeJmp0O4N/6Bz5+FMzWcX6jBlQiB9amMD1SKD 0AcVeMbTF+JSUwqGur+Mg1hgnYMpMJTRArVtCwgIT3zjLxyatO1PgKceV4rXsGGy kEESVipwGfoi1+zIdU2qvQKkSlDY5RhhTlpYK5YD/7JqmFGx0WnBq37ADgZegtiS J309KR4OP8RHKqRBA//qWW7JkOz9gXhiXx//+ZIq30/myKwEfxGt7OClpiVCAV29 Wk/M3pcXx6qY8o8lPUqzDjL2oqV+wgowRK6d/ePSY6D5ugVjdMLeoef0kG1ZgRV8 r3UN/WB6WYrh/fbQ+4dw/8wbRrn3VoyK+2GRbR2FMRBCHluEY9EClVN4uOGUkHyL 15q6jBNhWBo3zRA5qeCRk9Lex0pnThicdTXJ8Qc1pQ3iiyT7OKDyZRQbIytyKoUE 5a8JvcNf4SPQ/7BfHJxNURi7N5U0d01mkZssCTtPFGlBkuwI8yXPBMYI7rSzJ8qv 9fvqXHKmetryYsObBr2+NLa2GuXZUeHoJqV7xgBeMAVzPhq2OEFh3oLihP113Eoq sYpx/6XWWxlFKWmuBkkA8NQn2FEeX4KQPMnwq4MMNt+aIxxbn1o9tY1nhWqlkZ0R VUg2IAXbOGDRbxbzf/y3SCd/o2tRWW39GEzRsIKPAT53y2RodmQ= =e6+W -----END PGP SIGNATURE----- --kv3xxe43po3ksi5m--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190829133713.5l3jk67el47gdmfb>